git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Jones <pjones@redhat.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>, git@vger.kernel.org
Subject: Re: [PATCH] [git-am] Handle "git show" output correctly
Date: Wed, 12 Sep 2012 14:05:08 -0400	[thread overview]
Message-ID: <1347473108.12986.6.camel@eddie.install.bos.redhat.com> (raw)
In-Reply-To: <7v392ndu59.fsf@alter.siamese.dyndns.org>

On Wed, 2012-09-12 at 10:32 -0700, Junio C Hamano wrote:
> We do not want to apply "git show" output that munges the log
> message, period.
> 
> If you want to give patches to somebody (or to yourself) via e-mail
> or via sneaker-net, "git format-patch" is there for you.  Do not
> butcher "am" to accept a format that is not meant for patch
> transport in the first place.
> 
> If you want to screw something in to your shelf, you would use a
> screw and a screwdriver.  You do not try to hammer a nail using your
> screwdriver, find that the screwdriver is not very useful as a
> hammer and modify the screwdriver to hit your nail.

That seems to be completely missing the point - people /send/ them
without knowing, and as a maintainer of several projects, it's /hostile/
to people who are trying to help by sending patches to go around in
circles with them about the fact that they typed the wrong command. I'd
rather just take the patch, but right now the tools won't let me, and
for completely arbitrary reasons.

Let me put it a different way - if you won't accept git-am handling "git
show" output because "git show" has output that wasn't designed to be
parsed ever, would you be opposed to a patch that switches the "git
show" output to be something usable?

-- 
  Peter

  reply	other threads:[~2012-09-12 18:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 15:26 [PATCH] Handle "git show" output correctly Peter Jones
2012-09-12 15:30 ` Peter Jones
2012-09-12 15:41   ` Matthieu Moy
2012-09-12 15:49     ` [PATCH] [git-am] " Peter Jones
2012-09-12 15:57       ` Matthieu Moy
2012-09-12 17:32         ` Junio C Hamano
2012-09-12 18:05           ` Peter Jones [this message]
2012-09-12 19:07             ` Junio C Hamano
2012-09-12 15:42   ` [PATCH] " Peter Jones
2012-09-12 15:40 ` Matthieu Moy
2012-09-12 18:00   ` Peter Jones
2012-09-12 18:08     ` [PATCH] git-am: " Peter Jones
2012-09-12 20:06       ` Junio C Hamano
2012-09-12 20:48         ` Peter Jones
2012-09-12 21:03           ` Peter Jones
2012-09-12 21:18           ` Junio C Hamano
2012-09-12 21:26             ` Dan Johnson
2012-09-12 22:19               ` Junio C Hamano
2012-09-12 22:31                 ` Dan Johnson
2012-09-12 23:05                   ` Junio C Hamano
2012-09-12 22:41                 ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347473108.12986.6.camel@eddie.install.bos.redhat.com \
    --to=pjones@redhat.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).