From: Peter Jones <pjones@redhat.com>
To: git@vger.kernel.org
Cc: Peter Jones <pjones@redhat.com>
Subject: [PATCH] git-am: Handle "git show" output correctly
Date: Wed, 12 Sep 2012 14:08:24 -0400 [thread overview]
Message-ID: <1347473304-21418-1-git-send-email-pjones@redhat.com> (raw)
In-Reply-To: <1347472823.12986.3.camel@eddie.install.bos.redhat.com>
This patch adds the ability for "git am" to accept patches in the format
generated by "git show". Some people erroneously use "git show" instead
of "git format-patch", and it's nice as a maintainer to be able to
easily take their patch rather than going back and forth with them to
get a "correctly" formatted patch containing exactly the same actual
information.
Signed-off-by: Peter Jones <pjones@redhat.com>
---
git-am.sh | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)
diff --git a/git-am.sh b/git-am.sh
index c682d34..210e9fe 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -216,6 +216,21 @@ check_patch_format () {
read l2
read l3
case "$l1" in
+ "commit "*)
+ case "$l2" in
+ "Author: "*)
+ case "$l3" in
+ "Date: "*)
+ patch_format=gitshow
+ ;;
+ *)
+ ;;
+ esac
+ ;;
+ *)
+ ;;
+ esac
+ ;;
"From "* | "From: "*)
patch_format=mbox
;;
@@ -321,6 +336,51 @@ split_patches () {
this=
msgnum=
;;
+ gitshow)
+ this=0
+ for patch in "$@"
+ do
+ this=`expr "$this" + 1`
+ msgnum=`printf "%0${prec}d" $this`
+ # The first nonemptyline after an empty line is the
+ # subject, and the body starts with the next nonempty
+ # line.
+ perl -ne 'BEGIN {
+ $diff = 0; $subject = 0; $subjtext="";
+ }
+ if ($diff == 1 || /^diff/ || /^---$/) {
+ $diff = 1 ;
+ print ;
+ } elsif ($subject > 1) {
+ s/^ // ;
+ print ;
+ } elsif ($subject == 1 && !/^\s+$/) {
+ s/^ // ;
+ $subjtext = "$subjtext $_";
+ } elsif ($subject == 1) {
+ $subject = 2 ;
+ print "Subject: ", $subjtext ;
+ s/^ // ;
+ print ;
+ } elsif ($subject) {
+ print "\n" ;
+ s/^ // ;
+ print ;
+ } elsif (/^\s+$/) { next ; }
+ elsif (/^Author:/) { s/Author/From/ ; print ;}
+ elsif (/^(From|Date)/) { print ; }
+ elsif (/^commit/) { next ; }
+ else {
+ s/^ // ;
+ $subjtext = $_;
+ $subject = 1;
+ }
+ ' < "$patch" > "$dotest/$msgnum" || clean_abort
+ done
+ echo "$this" > "$dotest/last"
+ this=
+ msgnum=
+ ;;
hg)
this=0
for hg in "$@"
--
1.7.11.4
next prev parent reply other threads:[~2012-09-12 18:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 15:26 [PATCH] Handle "git show" output correctly Peter Jones
2012-09-12 15:30 ` Peter Jones
2012-09-12 15:41 ` Matthieu Moy
2012-09-12 15:49 ` [PATCH] [git-am] " Peter Jones
2012-09-12 15:57 ` Matthieu Moy
2012-09-12 17:32 ` Junio C Hamano
2012-09-12 18:05 ` Peter Jones
2012-09-12 19:07 ` Junio C Hamano
2012-09-12 15:42 ` [PATCH] " Peter Jones
2012-09-12 15:40 ` Matthieu Moy
2012-09-12 18:00 ` Peter Jones
2012-09-12 18:08 ` Peter Jones [this message]
2012-09-12 20:06 ` [PATCH] git-am: " Junio C Hamano
2012-09-12 20:48 ` Peter Jones
2012-09-12 21:03 ` Peter Jones
2012-09-12 21:18 ` Junio C Hamano
2012-09-12 21:26 ` Dan Johnson
2012-09-12 22:19 ` Junio C Hamano
2012-09-12 22:31 ` Dan Johnson
2012-09-12 23:05 ` Junio C Hamano
2012-09-12 22:41 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347473304-21418-1-git-send-email-pjones@redhat.com \
--to=pjones@redhat.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).