From: Andrew Wong <andrew.kw.w@gmail.com>
To: git@vger.kernel.org
Cc: Andrew Wong <andrew.kw.w@gmail.com>
Subject: [PATCH v2 3/3] rebase -i: Add tests for "--edit-todo"
Date: Sun, 16 Sep 2012 11:17:03 -0400 [thread overview]
Message-ID: <1347808623-1058-3-git-send-email-andrew.kw.w@gmail.com> (raw)
In-Reply-To: <1347808623-1058-1-git-send-email-andrew.kw.w@gmail.com>
Signed-off-by: Andrew Wong <andrew.kw.w@gmail.com>
---
t/t3404-rebase-interactive.sh | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index 7304b66..6eafb63 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -911,4 +911,22 @@ test_expect_success 'rebase -i --root fixup root commit' '
test 0 = $(git cat-file commit HEAD | grep -c ^parent\ )
'
+test_expect_success 'rebase --edit-todo does not works on non-interactive rebase' '
+ git reset --hard &&
+ git checkout conflict-branch &&
+ test_must_fail git rebase --onto HEAD~2 HEAD~ &&
+ test_must_fail git rebase --edit-todo &&
+ git rebase --abort
+'
+
+test_expect_success 'rebase --edit-todo can be used to modify todo' '
+ git reset --hard &&
+ git checkout no-conflict-branch^0 &&
+ FAKE_LINES="edit 1 2 3" git rebase -i HEAD~3 &&
+ FAKE_LINES="2 1" git rebase --edit-todo &&
+ git rebase --continue
+ test M = $(git cat-file commit HEAD^ | sed -ne \$p) &&
+ test L = $(git cat-file commit HEAD | sed -ne \$p)
+'
+
test_done
--
1.7.12.318.g79683ba.dirty
next prev parent reply other threads:[~2012-09-16 16:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 16:14 [RFC] Add "edit" action for interactive rebase? Andrew Wong
2012-09-10 16:14 ` [PATCH] rebase -i: Teach "--edit" action Andrew Wong
2012-09-10 16:25 ` Matthieu Moy
2012-09-10 16:46 ` Andrew Wong
2012-09-10 16:54 ` Jeff King
2012-09-10 18:36 ` Johannes Sixt
2012-09-10 18:46 ` Jeff King
2012-09-10 19:33 ` Andrew Wong
2012-09-10 19:57 ` Junio C Hamano
2012-09-10 21:17 ` Andrew Wong
2012-09-15 20:08 ` [PATCH 0/3] rebase -i: Teach "--edit-todo" Andrew Wong
2012-09-15 20:08 ` [PATCH 1/3] rebase -i: Refactor help messages for todo file Andrew Wong
2012-09-15 20:08 ` [PATCH 2/3] rebase -i: Teach "--edit-todo" action Andrew Wong
2012-09-16 6:54 ` Junio C Hamano
2012-09-16 15:49 ` Andrew Wong
2012-09-18 6:56 ` Junio C Hamano
2012-09-15 20:08 ` [PATCH 3/3] rebase -i: Add tests for "--edit-todo" Andrew Wong
2012-09-16 6:58 ` Junio C Hamano
2012-09-16 15:17 ` [PATCH v2 1/3] rebase -i: Refactor help messages for todo file Andrew Wong
2012-09-16 15:17 ` [PATCH v2 2/3] rebase -i: Teach "--edit-todo" action Andrew Wong
2012-09-17 6:11 ` Martin von Zweigbergk
2012-09-18 1:28 ` [PATCH v3 0/4] " Andrew Wong
2012-09-18 1:28 ` [PATCH 1/4] rebase usage: subcommands can not be combined with -i Andrew Wong
2012-09-18 1:28 ` [PATCH 2/4] rebase -i: Refactor help messages for todo file Andrew Wong
2012-09-18 1:28 ` [PATCH 3/4] rebase -i: Teach "--edit-todo" action Andrew Wong
2012-09-18 1:28 ` [PATCH 4/4] rebase -i: Add tests for "--edit-todo" Andrew Wong
2012-09-18 4:58 ` Martin von Zweigbergk
2012-09-18 5:23 ` Andrew Wong
2012-09-18 5:37 ` Martin von Zweigbergk
2012-09-19 6:43 ` [PATCH 5/4] rebase -i: suggest using --edit-todo to fix an unknown instruction Johannes Sixt
2012-09-19 19:52 ` Junio C Hamano
2012-09-16 15:17 ` Andrew Wong [this message]
2012-09-10 18:28 ` [RFC] Add "edit" action for interactive rebase? Johannes Sixt
2012-09-10 20:13 ` Andrew Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347808623-1058-3-git-send-email-andrew.kw.w@gmail.com \
--to=andrew.kw.w@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).