From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH] fetch-pack.h: remove unnecessary #include
Date: Mon, 17 Sep 2012 17:15:10 +0200 [thread overview]
Message-ID: <1347894910-27624-1-git-send-email-mhagger@alum.mit.edu> (raw)
Given the git project policy that *.c files that include header files
are responsible for including everything the headers they include
need, there is no need for fetch-pack.h to include string-list.h
itself. As for the files that include fetch-pack.h:
* builtin/clone.c and builtin/fetch-pack.c
include builtin.h
which includes notes.h
which includes string-list.h
* transport.c
includes string-list.h
so no other adjustments are needed.
Suggested by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
fetch-pack.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fetch-pack.h b/fetch-pack.h
index cb14871..018f35f 100644
--- a/fetch-pack.h
+++ b/fetch-pack.h
@@ -1,8 +1,6 @@
#ifndef FETCH_PACK_H
#define FETCH_PACK_H
-#include "string-list.h"
-
struct fetch_pack_args {
const char *uploadpack;
int unpacklimit;
--
1.7.11.3
reply other threads:[~2012-09-17 15:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347894910-27624-1-git-send-email-mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).