* [PATCH] fetch-pack.h: remove unnecessary #include
@ 2012-09-17 15:15 Michael Haggerty
0 siblings, 0 replies; only message in thread
From: Michael Haggerty @ 2012-09-17 15:15 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Michael Haggerty
Given the git project policy that *.c files that include header files
are responsible for including everything the headers they include
need, there is no need for fetch-pack.h to include string-list.h
itself. As for the files that include fetch-pack.h:
* builtin/clone.c and builtin/fetch-pack.c
include builtin.h
which includes notes.h
which includes string-list.h
* transport.c
includes string-list.h
so no other adjustments are needed.
Suggested by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
fetch-pack.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fetch-pack.h b/fetch-pack.h
index cb14871..018f35f 100644
--- a/fetch-pack.h
+++ b/fetch-pack.h
@@ -1,8 +1,6 @@
#ifndef FETCH_PACK_H
#define FETCH_PACK_H
-#include "string-list.h"
-
struct fetch_pack_args {
const char *uploadpack;
int unpacklimit;
--
1.7.11.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-09-17 15:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-17 15:15 [PATCH] fetch-pack.h: remove unnecessary #include Michael Haggerty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).