From: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
To: GIT Mailing-list <git@vger.kernel.org>
Cc: David Michael Barr <b@rr-dav.id.au>,
Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Subject: [PATCH v8 03/16] Add svndump_init_fd to allow reading dumps from arbitrary FDs
Date: Wed, 19 Sep 2012 17:21:17 +0200 [thread overview]
Message-ID: <1348068090-31988-4-git-send-email-florian.achleitner.2.6.31@gmail.com> (raw)
In-Reply-To: <1348068090-31988-3-git-send-email-florian.achleitner.2.6.31@gmail.com>
The existing function only allows reading from a filename or from
stdin. Allow passing of a FD and an additional FD for the back report
pipe. This allows us to retrieve the name of the pipe in the caller.
Signed-off-by: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
no diff
vcs-svn/svndump.c | 22 ++++++++++++++++++----
vcs-svn/svndump.h | 1 +
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c
index 2b168ae..d81a078 100644
--- a/vcs-svn/svndump.c
+++ b/vcs-svn/svndump.c
@@ -468,11 +468,9 @@ void svndump_read(const char *url)
end_revision();
}
-int svndump_init(const char *filename)
+static void init(int report_fd)
{
- if (buffer_init(&input, filename))
- return error("cannot open %s: %s", filename, strerror(errno));
- fast_export_init(REPORT_FILENO);
+ fast_export_init(report_fd);
strbuf_init(&dump_ctx.uuid, 4096);
strbuf_init(&dump_ctx.url, 4096);
strbuf_init(&rev_ctx.log, 4096);
@@ -482,6 +480,22 @@ int svndump_init(const char *filename)
reset_dump_ctx(NULL);
reset_rev_ctx(0);
reset_node_ctx(NULL);
+ return;
+}
+
+int svndump_init(const char *filename)
+{
+ if (buffer_init(&input, filename))
+ return error("cannot open %s: %s", filename ? filename : "NULL", strerror(errno));
+ init(REPORT_FILENO);
+ return 0;
+}
+
+int svndump_init_fd(int in_fd, int back_fd)
+{
+ if(buffer_fdinit(&input, xdup(in_fd)))
+ return error("cannot open fd %d: %s", in_fd, strerror(errno));
+ init(xdup(back_fd));
return 0;
}
diff --git a/vcs-svn/svndump.h b/vcs-svn/svndump.h
index df9ceb0..acb5b47 100644
--- a/vcs-svn/svndump.h
+++ b/vcs-svn/svndump.h
@@ -2,6 +2,7 @@
#define SVNDUMP_H_
int svndump_init(const char *filename);
+int svndump_init_fd(int in_fd, int back_fd);
void svndump_read(const char *url);
void svndump_deinit(void);
void svndump_reset(void);
--
1.7.9.5
next prev parent reply other threads:[~2012-09-19 15:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 15:21 [PATCH v8 00/16] GSOC remote-svn Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 01/16] Implement a remote helper for svn in C Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 02/16] Add git-remote-testsvn to Makefile Florian Achleitner
2012-09-19 15:21 ` Florian Achleitner [this message]
2012-09-19 15:21 ` [PATCH v8 04/16] Add argv_array_detach and argv_array_free_detached Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 05/16] Connect fast-import to the remote-helper via pipe, adding 'bidi-import' capability Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 06/16] Add documentation for the 'bidi-import' capability of remote-helpers Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 07/16] When debug==1, start fast-import with "--stats" instead of "--quiet" Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 08/16] remote-svn, vcs-svn: Enable fetching to private refs Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 09/16] Allow reading svn dumps from files via file:// urls Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 10/16] vcs-svn: add fast_export_note to create notes Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 11/16] Create a note for every imported commit containing svn metadata Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 12/16] remote-svn: Activate import/export-marks for fast-import Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 13/16] remote-svn: add incremental import Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 14/16] Add a svnrdump-simulator replaying a dump file for testing Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 15/16] remote-svn: add marks-file regeneration Florian Achleitner
2012-09-19 15:21 ` [PATCH v8 16/16] Add a test script for remote-svn Florian Achleitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348068090-31988-4-git-send-email-florian.achleitner.2.6.31@gmail.com \
--to=florian.achleitner.2.6.31@gmail.com \
--cc=b@rr-dav.id.au \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).