From: Adam Spiers <git@adamspiers.org>
To: git list <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: [PATCH v2 5/6] Test the test framework more thoroughly
Date: Wed, 19 Sep 2012 18:15:14 +0100 [thread overview]
Message-ID: <1348074915-19985-6-git-send-email-git@adamspiers.org> (raw)
In-Reply-To: <1348074915-19985-1-git-send-email-git@adamspiers.org>
Add 5 new full test suite runs each with a different number of
passing/failing/broken/fixed tests, in order to ensure that the
correct exit code and output are generated in each case. As before,
these are run in a subdirectory in order to disrupt the metrics for
the parent tests.
Signed-off-by: Adam Spiers <git@adamspiers.org>
---
t/t0000-basic.sh | 110 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 110 insertions(+)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 662cd2f..644cc2c 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -77,6 +77,15 @@ run_sub_test_lib_test () {
./$name.sh >out 2>err)
}
+run_sub_test_lib_test_expecting_failures () {
+ if run_sub_test_lib_test "$@"; then
+ echo 'sub test-lib run should have failed'
+ return 1
+ else
+ return 0
+ fi
+}
+
check_sub_test_lib_test () {
name="$1" # stdin is test's expected stdout
(cd $name &&
@@ -85,6 +94,54 @@ check_sub_test_lib_test () {
test_cmp expect out)
}
+test_expect_success 'pretend we have a fully passing test suite' "
+ run_sub_test_lib_test full-pass '3 passing tests' <<-EOF &&
+ for i in 1 2 3; do
+ test_expect_success \"passing test #\\\$i\" 'true'
+ done
+ test_done
+ EOF
+ check_sub_test_lib_test full-pass <<-EOF
+ > ok 1 - passing test #1
+ > ok 2 - passing test #2
+ > ok 3 - passing test #3
+ > # passed all 3 test(s)
+ > 1..3
+ EOF
+"
+
+test_expect_success 'pretend we have a partially passing test suite' "
+ run_sub_test_lib_test_expecting_failures partial-pass '2/3 tests passing' <<-EOF &&
+ test_expect_success 'passing test #1' 'true'
+ test_expect_success 'failing test #2' 'false'
+ test_expect_success 'passing test #3' 'true'
+ test_done
+ EOF
+ check_sub_test_lib_test partial-pass <<-EOF
+ > ok 1 - passing test #1
+ > not ok 2 - failing test #2
+ # false
+ > ok 3 - passing test #3
+ > # failed 1 among 3 test(s)
+ > 1..3
+ EOF
+"
+
+test_expect_success 'pretend we have a known breakage' "
+ run_sub_test_lib_test failing-todo 'A failing TODO test' <<-EOF &&
+ test_expect_success 'passing test' 'true'
+ test_expect_failure 'pretend we have a known breakage' 'false'
+ test_done
+ EOF
+ check_sub_test_lib_test failing-todo <<-EOF
+ > ok 1 - passing test
+ > not ok 2 - pretend we have a known breakage # TODO known breakage
+ > # still have 1 known breakage(s)
+ > # passed all remaining 1 test(s)
+ > 1..2
+ EOF
+"
+
test_expect_success 'pretend we have fixed a known breakage' "
run_sub_test_lib_test passing-todo 'A passing TODO test' <<-EOF &&
test_expect_failure 'pretend we have fixed a known breakage' 'true'
@@ -98,6 +155,59 @@ test_expect_success 'pretend we have fixed a known breakage' "
EOF
"
+test_expect_success 'pretend we have a pass, fail, and known breakage' "
+ run_sub_test_lib_test_expecting_failures mixed-results1 'mixed results #1' <<-EOF &&
+ test_expect_success 'passing test' 'true'
+ test_expect_success 'failing test' 'false'
+ test_expect_failure 'pretend we have a known breakage' 'false'
+ test_done
+ EOF
+ check_sub_test_lib_test mixed-results1 <<-EOF
+ > ok 1 - passing test
+ > not ok 2 - failing test
+ > # false
+ > not ok 3 - pretend we have a known breakage # TODO known breakage
+ > # still have 1 known breakage(s)
+ > # failed 1 among remaining 2 test(s)
+ > 1..3
+ EOF
+"
+
+test_expect_success 'pretend we have a mix of all possible results' "
+ run_sub_test_lib_test_expecting_failures mixed-results2 'mixed results #2' <<-EOF &&
+ test_expect_success 'passing test' 'true'
+ test_expect_success 'passing test' 'true'
+ test_expect_success 'passing test' 'true'
+ test_expect_success 'passing test' 'true'
+ test_expect_success 'failing test' 'false'
+ test_expect_success 'failing test' 'false'
+ test_expect_success 'failing test' 'false'
+ test_expect_failure 'pretend we have a known breakage' 'false'
+ test_expect_failure 'pretend we have a known breakage' 'false'
+ test_expect_failure 'pretend we have fixed a known breakage' 'true'
+ test_done
+ EOF
+ check_sub_test_lib_test mixed-results2 <<-EOF
+ > ok 1 - passing test
+ > ok 2 - passing test
+ > ok 3 - passing test
+ > ok 4 - passing test
+ > not ok 5 - failing test
+ > # false
+ > not ok 6 - failing test
+ > # false
+ > not ok 7 - failing test
+ > # false
+ > not ok 8 - pretend we have a known breakage # TODO known breakage
+ > not ok 9 - pretend we have a known breakage # TODO known breakage
+ > ok 10 - pretend we have fixed a known breakage # TODO known breakage
+ > # fixed 1 known breakage(s)
+ > # still have 2 known breakage(s)
+ > # failed 3 among remaining 8 test(s)
+ > 1..10
+ EOF
+"
+
test_set_prereq HAVEIT
haveit=no
test_expect_success HAVEIT 'test runs if prerequisite is satisfied' '
--
1.7.12.147.g6d168f4
next prev parent reply other threads:[~2012-09-19 17:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 11:50 [PATCH] Make test output coloring more intuitive Adam Spiers
2012-09-17 20:11 ` Jeff King
2012-09-18 21:21 ` Adam Spiers
2012-09-19 20:02 ` Stefano Lattarini
2012-09-19 20:12 ` Adam Spiers
2012-09-19 20:13 ` Jeff King
2012-09-19 20:24 ` [PATCH v4 3/6] Color skipped tests blue Adam Spiers
2012-09-20 5:48 ` Johannes Sixt
2012-09-20 9:04 ` Adam Spiers
2012-09-20 9:08 ` [PATCH v5 3/3] Color skipped tests bold blue Adam Spiers
2012-09-20 10:08 ` Stefano Lattarini
2012-09-20 16:20 ` Junio C Hamano
2012-09-21 6:13 ` [PATCH v4 3/6] Color skipped tests blue Jeff King
2012-11-11 2:04 ` Adam Spiers
2012-09-17 20:50 ` [PATCH] Make test output coloring more intuitive Junio C Hamano
2012-09-18 21:36 ` Adam Spiers
2012-09-18 21:59 ` Jeff King
2012-09-18 22:14 ` Adam Spiers
2012-09-19 17:15 ` [PATCH v2 0/6] make " Adam Spiers
2012-09-19 17:15 ` [PATCH v2 1/6] Change the color of individual known breakages Adam Spiers
2012-09-19 17:15 ` [PATCH v2 2/6] Make 'not ok $count - $message' consistent with 'ok $count - $message' Adam Spiers
2012-09-19 17:50 ` Jeff King
2012-09-19 23:39 ` Junio C Hamano
2012-09-19 23:45 ` Adam Spiers
2012-09-19 17:15 ` [PATCH v2 3/6] Color skipped tests the same as informational messages Adam Spiers
2012-09-19 17:15 ` [PATCH v2 4/6] Refactor mechanics of testing in a sub test-lib Adam Spiers
2012-09-19 17:56 ` Jeff King
2012-09-19 18:44 ` Adam Spiers
2012-09-19 18:49 ` [PATCH v3 " Adam Spiers
2012-09-19 18:49 ` [PATCH v3 5/6] Test the test framework more thoroughly Adam Spiers
2012-09-19 18:49 ` [PATCH v3 6/6] Treat unexpectedly fixed known breakages more seriously Adam Spiers
2012-09-20 21:13 ` [PATCH v3 4/6] Refactor mechanics of testing in a sub test-lib Junio C Hamano
2012-09-19 19:37 ` [PATCH v2 " Jeff King
2012-09-19 20:15 ` Adam Spiers
2012-09-19 17:15 ` Adam Spiers [this message]
2012-09-19 17:15 ` [PATCH v2 6/6] Treat unexpectedly fixed known breakages more seriously Adam Spiers
2012-09-19 18:05 ` [PATCH v2 0/6] make test output coloring more intuitive Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348074915-19985-6-git-send-email-git@adamspiers.org \
--to=git@adamspiers.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).