From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Subject: [PATCH] t/test-lib.sh: do not trust $SHELL
Date: Sat, 22 Sep 2012 02:22:46 +0530 [thread overview]
Message-ID: <1348260766-25287-1-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <505CCA55.6030609@gmail.com>
Replace $SHELL with an explicit `/bin/sh`, as some shells do not
support all the features used in the script. For example, ZSH does
not respect IFS, which is used in line 478.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
t/test-lib.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index f8e3733..5710488 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -24,7 +24,7 @@ done,*)
*' --tee '*|*' --va'*)
mkdir -p test-results
BASE=test-results/$(basename "$0" .sh)
- (GIT_TEST_TEE_STARTED=done ${SHELL-sh} "$0" "$@" 2>&1;
+ (GIT_TEST_TEE_STARTED=done /bin/sh "$0" "$@" 2>&1;
echo $? > $BASE.exit) | tee $BASE.out
test "$(cat $BASE.exit)" = 0
exit
--
1.7.8.1.362.g5d6df.dirty
next prev parent reply other threads:[~2012-09-21 20:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 17:01 How do I run tests under Valgrind? Ramkumar Ramachandra
2012-09-17 17:20 ` Jeff King
2012-09-17 17:23 ` Ramkumar Ramachandra
2012-09-17 17:35 ` Jeff King
2012-09-17 17:39 ` Ramkumar Ramachandra
2012-09-17 17:44 ` Jeff King
2012-09-17 17:55 ` Johannes Sixt
2012-09-17 17:57 ` Jeff King
2012-09-17 18:28 ` Ramkumar Ramachandra
[not found] ` <CALkWK0mkBbY7dUyaZAqqKE3ZMfE_xU6em_KCOKM9nsTjUP-9pA@mail.gmail.com>
2012-09-17 18:29 ` Jeff King
2012-09-21 19:31 ` Ramkumar Ramachandra
2012-09-21 19:58 ` Ramkumar Ramachandra
2012-09-21 20:13 ` Stefano Lattarini
2012-09-21 20:17 ` Ramkumar Ramachandra
2012-09-21 20:46 ` Ramkumar Ramachandra
2012-09-21 20:49 ` Jeff King
2012-09-22 13:03 ` Stefano Lattarini
2012-09-22 17:47 ` Jeff King
2012-09-22 18:20 ` Stefano Lattarini
2012-09-22 20:24 ` Junio C Hamano
2012-09-21 20:52 ` Ramkumar Ramachandra [this message]
2012-09-21 20:58 ` [PATCH] t/test-lib.sh: do not trust $SHELL Jeff King
2012-09-21 21:07 ` Ramkumar Ramachandra
2012-09-21 21:12 ` Jeff King
2012-09-21 21:34 ` Ramkumar Ramachandra
2012-09-21 21:57 ` Andreas Schwab
2012-09-21 22:30 ` Junio C Hamano
2012-09-22 4:26 ` Ramkumar Ramachandra
2012-09-22 4:52 ` Junio C Hamano
2012-09-22 4:54 ` Ramkumar Ramachandra
2012-09-22 4:57 ` Ramkumar Ramachandra
2012-09-22 20:16 ` Junio C Hamano
2012-09-26 3:49 ` Ramkumar Ramachandra
2012-09-21 21:59 ` Junio C Hamano
2012-09-21 22:15 ` Jeff King
2012-09-21 21:08 ` Andreas Schwab
2012-09-21 21:13 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348260766-25287-1-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).