From: Ryan Cumming <etaoins@gmail.com>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Ryan Cumming <etaoins@gmail.com>
Subject: [PATCH] Teach git-completion about git p4
Date: Fri, 21 Sep 2012 14:51:11 -0700 [thread overview]
Message-ID: <1348264271-99395-1-git-send-email-rcumming@ea.com> (raw)
From: Ryan Cumming <etaoins@gmail.com>
git p4 was moved out of contrib in 1.7.11 but it git-completion didn't
know about it. Add git p4 completion based on the existing SVN
completion. It covers all known subcommands and options except for the
-/ option for clone which doesn't use the standard -- prefix.
Signed-off-by: Ryan Cumming <etaoins@gmail.com>
---
contrib/completion/git-completion.bash | 44 ++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index c48cd19..c6140be 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1459,6 +1459,50 @@ _git_notes ()
esac
}
+_git_p4 ()
+{
+ local subcommands="
+ clone sync rebase submit
+ "
+ local subcommand="$(__git_find_on_cmdline "$subcommands")"
+ if [ -z "$subcommand" ]; then
+ __gitcomp "$subcommands"
+ else
+ local common_opts="--git-dir= --verbose"
+ local sync_opts="
+ --branch= --detect-branches --changes-file=
+ --silent --detect-labels --import-labels
+ --import-local --max-changes= --keep-path
+ --use-client-spec $common_opts
+ "
+ local clone_opts="
+ --destination= --bare $sync_opts
+ "
+ local submit_opts="
+ --origin= -M --preserve-user --export-labels
+ $common_opts
+ "
+
+ case "$subcommand,$cur" in
+ clone,--*)
+ __gitcomp "$clone_opts"
+ ;;
+ sync,--*)
+ __gitcomp "$sync_opts"
+ ;;
+ rebase,--*)
+ __gitcomp "$common_opts --import-labels"
+ ;;
+ submit,--*)
+ __gitcomp "$submit_opts"
+ ;;
+ submit,*)
+ __gitcomp "$(__git_refs)"
+ ;;
+ esac
+ fi
+}
+
_git_pull ()
{
__git_complete_strategy && return
--
1.7.12.1
next reply other threads:[~2012-09-21 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 21:51 Ryan Cumming [this message]
2012-09-24 16:12 ` [PATCH] Teach git-completion about git p4 Junio C Hamano
2012-09-26 0:48 ` Pete Wyckoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348264271-99395-1-git-send-email-rcumming@ea.com \
--to=etaoins@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).