From: Andrew Wong <andrew.kw.w@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, szeder@ira.uka.de, paulus@samba.org,
Andrew Wong <andrew.kw.w@gmail.com>
Subject: [PATCH v2 1/2] gitk: Refactor code for binding modified function keys
Date: Tue, 2 Oct 2012 11:04:44 -0400 [thread overview]
Message-ID: <1349190285-7788-2-git-send-email-andrew.kw.w@gmail.com> (raw)
In-Reply-To: <1349190285-7788-1-git-send-email-andrew.kw.w@gmail.com>
The function includes a workaround for systems where F* keys are mapped
to XF86_Switch_VT_* when modifiers are used.
Signed-off-by: Andrew Wong <andrew.kw.w@gmail.com>
---
gitk | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/gitk b/gitk
index 379582a..f8f89a5 100755
--- a/gitk
+++ b/gitk
@@ -2503,8 +2503,7 @@ proc makewindow {} {
bind . <F5> updatecommits
bind . <Shift-F5> reloadcommits
bind . <F2> showrefs
- bind . <Shift-F4> {newview 0}
- catch { bind . <Shift-Key-XF86_Switch_VT_4> {newview 0} }
+ bindmodfunctionkey Shift 4 {newview 0}
bind . <F4> edit_or_newview
bind . <$M1B-q> doquit
bind . <$M1B-f> {dofind 1 1}
@@ -2653,6 +2652,11 @@ proc bindkey {ev script} {
}
}
+proc bindmodfunctionkey {mod n script} {
+ bind . <$mod-F$n> $script
+ catch { bind . <$mod-XF86_Switch_VT_$n> $script }
+}
+
# set the focus back to the toplevel for any click outside
# the entry widgets
proc click {w} {
--
1.7.12.1.382.gb0576a6
next prev parent reply other threads:[~2012-10-02 15:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 10:19 gitk: can't reload commits with new key binding SZEDER Gábor
2012-10-01 15:26 ` Andrew Wong
2012-10-01 15:26 ` [PATCH] gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5 Andrew Wong
2012-10-01 17:27 ` Junio C Hamano
2012-10-02 15:04 ` [PATCH v2 0/2] Re: gitk: can't reload commits with new key binding Andrew Wong
2012-10-02 15:04 ` Andrew Wong [this message]
2012-10-02 15:04 ` [PATCH v2 2/2] gitk: Use bindshiftfunctionkey to bind Shift-F5 Andrew Wong
2012-10-07 21:18 ` [PATCH v2 0/2] Re: gitk: can't reload commits with new key binding Andrew Wong
2012-10-08 21:05 ` SZEDER Gábor
2012-10-12 14:17 ` Andrew Wong
2012-10-21 22:19 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349190285-7788-2-git-send-email-andrew.kw.w@gmail.com \
--to=andrew.kw.w@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=paulus@samba.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).