From: Johannes Sixt <j6t@kdbg.org>
To: Ben Peart <peartben@gmail.com>
Cc: Jeff King <peff@peff.net>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, gitster@pobox.com, benpeart@microsoft.com,
pclouds@gmail.com, johannes.schindelin@gmx.de,
David.Turner@twosigma.com
Subject: Re: [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to speed up detecting new or changed files.
Date: Tue, 16 May 2017 21:13:58 +0200 [thread overview]
Message-ID: <134ea57f-3a64-f7b5-67dd-8b14ff3cc04a@kdbg.org> (raw)
In-Reply-To: <29122818-71fb-5af9-59b1-03387f014151@gmail.com>
Am 16.05.2017 um 19:17 schrieb Ben Peart:
> OK, now I'm confused as to the best path for adding a get_be64. This
> one is trivial:
>
> #define get_be64(p) ntohll(*(uint64_t *)(p))
I cringe when I see a cast like this. Unless you can guarantee that p is
char* (bare or signed or unsigned), you fall pray to strict aliasing
violations, aka undefined behavior. And I'm not even mentioning correct
alignment, yet.
-- Hannes
next prev parent reply other threads:[~2017-05-16 19:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 19:13 [PATCH v1 0/5] Fast git status via a file system watcher Ben Peart
2017-05-15 19:13 ` [PATCH v1 1/5] dir: make lookup_untracked() available outside of dir.c Ben Peart
2017-05-16 5:01 ` Junio C Hamano
2017-05-15 19:13 ` [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to speed up detecting new or changed files Ben Peart
2017-05-15 21:21 ` David Turner
2017-05-16 1:15 ` Ben Peart
2017-05-16 0:22 ` brian m. carlson
2017-05-16 0:34 ` Jeff King
2017-05-16 1:55 ` Ben Peart
2017-05-16 2:51 ` Jeff King
2017-05-16 17:17 ` Ben Peart
2017-05-16 17:49 ` Jeff King
2017-05-16 19:13 ` Johannes Sixt [this message]
2017-05-17 14:26 ` Ben Peart
2017-05-17 18:15 ` Johannes Sixt
2017-05-18 4:52 ` Jeff King
2017-05-16 21:41 ` Jonathan Tan
2017-05-17 3:35 ` Ben Peart
2017-05-15 19:13 ` [PATCH v1 3/5] fsmonitor: add test cases for fsmonitor extension Ben Peart
2017-05-16 4:59 ` Junio C Hamano
2017-05-16 14:28 ` Ben Peart
2017-05-15 19:13 ` [PATCH v1 4/5] Add documentation for the fsmonitor extension. This includes the core.fsmonitor setting, the query-fsmonitor hook, and the fsmonitor index extension Ben Peart
2017-05-15 19:13 ` [PATCH v1 5/5] Add a sample query-fsmonitor hook script that integrates with the cross platform Watchman file watching service Ben Peart
2017-05-15 19:50 ` David Turner
2017-05-15 20:10 ` Ben Peart
2017-05-16 5:00 ` [PATCH v1 0/5] Fast git status via a file system watcher Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=134ea57f-3a64-f7b5-67dd-8b14ff3cc04a@kdbg.org \
--to=j6t@kdbg.org \
--cc=David.Turner@twosigma.com \
--cc=benpeart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=pclouds@gmail.com \
--cc=peartben@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).