From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 7AC861FAA8 for ; Tue, 16 May 2017 19:14:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbdEPTOC (ORCPT ); Tue, 16 May 2017 15:14:02 -0400 Received: from bsmtp1.bon.at ([213.33.87.15]:8791 "EHLO bsmtp1.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784AbdEPTOB (ORCPT ); Tue, 16 May 2017 15:14:01 -0400 Received: from dx.site (unknown [93.83.142.38]) by bsmtp1.bon.at (Postfix) with ESMTPSA id 3wS6Yz3C1hz5tl9; Tue, 16 May 2017 21:13:59 +0200 (CEST) Received: from [IPv6:::1] (localhost [IPv6:::1]) by dx.site (Postfix) with ESMTP id F3DC84308; Tue, 16 May 2017 21:13:58 +0200 (CEST) Subject: Re: [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to speed up detecting new or changed files. To: Ben Peart References: <20170515191347.1892-1-benpeart@microsoft.com> <20170515191347.1892-3-benpeart@microsoft.com> <20170516002214.tlqkk4zrwdzcdjha@genre.crustytoothpaste.net> <20170516003414.yliltu5fsaudfhyu@sigill.intra.peff.net> <2d965a87-36da-23b4-4bc5-97de47f3d7f7@gmail.com> <29122818-71fb-5af9-59b1-03387f014151@gmail.com> Cc: Jeff King , "brian m. carlson" , git@vger.kernel.org, gitster@pobox.com, benpeart@microsoft.com, pclouds@gmail.com, johannes.schindelin@gmx.de, David.Turner@twosigma.com From: Johannes Sixt Message-ID: <134ea57f-3a64-f7b5-67dd-8b14ff3cc04a@kdbg.org> Date: Tue, 16 May 2017 21:13:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <29122818-71fb-5af9-59b1-03387f014151@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Am 16.05.2017 um 19:17 schrieb Ben Peart: > OK, now I'm confused as to the best path for adding a get_be64. This > one is trivial: > > #define get_be64(p) ntohll(*(uint64_t *)(p)) I cringe when I see a cast like this. Unless you can guarantee that p is char* (bare or signed or unsigned), you fall pray to strict aliasing violations, aka undefined behavior. And I'm not even mentioning correct alignment, yet. -- Hannes