From: Joe Perches <joe@perches.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Pascal Obry <pascal@obry.net>
Subject: Re: [PATCH 2/2] send-email: add series-cc-cmd option
Date: Mon, 12 Nov 2012 15:13:02 -0800 [thread overview]
Message-ID: <1352761982.18715.20.camel@joe-AO722> (raw)
In-Reply-To: <CAMP44s0B42yt8eugYSjYweoX8WOXXF1f-0N-5FuUyrY5rgCiow@mail.gmail.com>
On Tue, 2012-11-13 at 00:03 +0100, Felipe Contreras wrote:
> On Mon, Nov 12, 2012 at 11:52 PM, Joe Perches <joe@perches.com> wrote:
> > On Tue, 2012-11-13 at 03:21 +0530, Ramkumar Ramachandra wrote:
> >> Felipe Contreras wrote:
> >> > cc-cmd is only per-file, and many times receipients get lost without
> >> > seing the full patch series.
> >>
> >> s/seing/seeing
> >>
> >> > [...]
> >>
> >> Looks good otherwise.
> >
> > s/receipients/recipients/ too
> >
> > Practically this is ok but I think it's unnecessary.
> >
> > Output from git format-patch is always in a single
> > directory.
>
> A temporary directory.
>
> > My work flow is to use a script for --to and --cc
> > lines that can be set to emit the same addresses for
> > all files in a patch series or generate different
> > addresses per patch file.
>
> For --to-cmd and --cc-cmd? So basically you check the dirname of the
> argument passed?
yes. basename and dirname
> While that works, it means you have to run the same command multiple
> times, one for each mail.
Shrug. it's not a generally significant cost.
The script could also output the addresses to yet another file.
> If the command is using something expensive such as 'git blame' and
> you have many patches, this is particularly bad. Also, it's not
> elegant :)
Elegant is a beholder viewpoint.
cheers, Joe
next prev parent reply other threads:[~2012-11-12 23:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 17:04 [PATCH 0/2] send-email: new series-cc-cmd option Felipe Contreras
2012-11-11 17:04 ` [PATCH 1/2] send-email: refactor recipients_cmd() Felipe Contreras
2012-11-11 17:04 ` [PATCH 2/2] send-email: add series-cc-cmd option Felipe Contreras
2012-11-12 21:51 ` Ramkumar Ramachandra
2012-11-12 22:52 ` Joe Perches
2012-11-12 23:03 ` Felipe Contreras
2012-11-12 23:13 ` Joe Perches [this message]
2012-11-12 23:37 ` Felipe Contreras
2012-11-12 23:40 ` Joe Perches
2012-11-13 0:37 ` Junio C Hamano
2012-11-13 1:01 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352761982.18715.20.camel@joe-AO722 \
--to=joe@perches.com \
--cc=artagnon@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pascal@obry.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).