From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 2/2] send-email: add series-cc-cmd option Date: Mon, 12 Nov 2012 15:13:02 -0800 Message-ID: <1352761982.18715.20.camel@joe-AO722> References: <1352653463-1923-1-git-send-email-felipe.contreras@gmail.com> <1352653463-1923-3-git-send-email-felipe.contreras@gmail.com> <1352760759.18715.7.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Ramkumar Ramachandra , git@vger.kernel.org, Junio C Hamano , Jonathan Nieder , Pascal Obry To: Felipe Contreras X-From: git-owner@vger.kernel.org Tue Nov 13 00:13:19 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TY3Bu-0000OT-MF for gcvg-git-2@plane.gmane.org; Tue, 13 Nov 2012 00:13:19 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754102Ab2KLXND (ORCPT ); Mon, 12 Nov 2012 18:13:03 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:46531 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754081Ab2KLXNC (ORCPT ); Mon, 12 Nov 2012 18:13:02 -0500 Received: from [173.51.221.202] (account joe@perches.com HELO [192.168.1.167]) by labridge.com (CommuniGate Pro SMTP 5.0.14) with ESMTPA id 19833203; Mon, 12 Nov 2012 15:13:01 -0800 In-Reply-To: X-Mailer: Evolution 3.6.0-0ubuntu3 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Tue, 2012-11-13 at 00:03 +0100, Felipe Contreras wrote: > On Mon, Nov 12, 2012 at 11:52 PM, Joe Perches wrote: > > On Tue, 2012-11-13 at 03:21 +0530, Ramkumar Ramachandra wrote: > >> Felipe Contreras wrote: > >> > cc-cmd is only per-file, and many times receipients get lost without > >> > seing the full patch series. > >> > >> s/seing/seeing > >> > >> > [...] > >> > >> Looks good otherwise. > > > > s/receipients/recipients/ too > > > > Practically this is ok but I think it's unnecessary. > > > > Output from git format-patch is always in a single > > directory. > > A temporary directory. > > > My work flow is to use a script for --to and --cc > > lines that can be set to emit the same addresses for > > all files in a patch series or generate different > > addresses per patch file. > > For --to-cmd and --cc-cmd? So basically you check the dirname of the > argument passed? yes. basename and dirname > While that works, it means you have to run the same command multiple > times, one for each mail. Shrug. it's not a generally significant cost. The script could also output the addresses to yet another file. > If the command is using something expensive such as 'git blame' and > you have many patches, this is particularly bad. Also, it's not > elegant :) Elegant is a beholder viewpoint. cheers, Joe