From: Erik Faye-Lund <kusmabite@gmail.com>
To: git@vger.kernel.org, msysgit@googlegroups.com
Cc: peff@peff.net
Subject: [PATCH/RFC 5/5] mingw: get rid of getpass implementation
Date: Tue, 13 Nov 2012 15:04:07 +0100 [thread overview]
Message-ID: <1352815447-8824-6-git-send-email-kusmabite@gmail.com> (raw)
In-Reply-To: <1352815447-8824-1-git-send-email-kusmabite@gmail.com>
There's no remaining call-sites, and as pointed out in the
previous commit message, it's not quite ideal. So let's just
lose it.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
compat/mingw.c | 15 ---------------
compat/mingw.h | 2 --
2 files changed, 17 deletions(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index 33ddfdf..5fc14b7 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -1758,21 +1758,6 @@ int link(const char *oldpath, const char *newpath)
return 0;
}
-char *getpass(const char *prompt)
-{
- struct strbuf buf = STRBUF_INIT;
-
- fputs(prompt, stderr);
- for (;;) {
- char c = _getch();
- if (c == '\r' || c == '\n')
- break;
- strbuf_addch(&buf, c);
- }
- fputs("\n", stderr);
- return strbuf_detach(&buf, NULL);
-}
-
pid_t waitpid(pid_t pid, int *status, int options)
{
HANDLE h = OpenProcess(SYNCHRONIZE | PROCESS_QUERY_INFORMATION,
diff --git a/compat/mingw.h b/compat/mingw.h
index 6b9e69a..f494ecb 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -55,8 +55,6 @@ struct passwd {
char *pw_dir;
};
-extern char *getpass(const char *prompt);
-
typedef void (__cdecl *sig_handler_t)(int);
struct sigaction {
sig_handler_t sa_handler;
--
1.8.0.7.gbeffeda
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
next prev parent reply other threads:[~2012-11-13 14:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 14:04 [PATCH/RFC 0/5] win32: support echo for terminal-prompt Erik Faye-Lund
2012-11-13 14:04 ` [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate Erik Faye-Lund
2012-11-30 17:58 ` Johannes Schindelin
2012-11-30 18:11 ` [msysGit] " Jeff King
2012-12-01 12:31 ` Erik Faye-Lund
2012-12-01 17:39 ` Jeff King
2012-12-01 12:36 ` Erik Faye-Lund
2012-12-04 17:12 ` Johannes Schindelin
2012-12-04 17:40 ` Erik Faye-Lund
2012-12-02 10:42 ` Junio C Hamano
2012-12-03 23:29 ` Erik Faye-Lund
2012-12-04 0:23 ` Junio C Hamano
2012-11-13 14:04 ` [PATCH/RFC 2/5] compat/terminal: factor out echo-disabling Erik Faye-Lund
2012-11-30 17:59 ` Johannes Schindelin
2012-11-30 18:19 ` Jeff King
2012-12-01 12:43 ` Erik Faye-Lund
2012-12-04 17:12 ` Johannes Schindelin
2012-11-13 14:04 ` [PATCH/RFC 3/5] compat/terminal: separate input and output handles Erik Faye-Lund
2012-11-30 18:22 ` Jeff King
2012-11-13 14:04 ` [PATCH/RFC 4/5] mingw: reuse tty-version of git_terminal_prompt Erik Faye-Lund
2012-11-30 18:05 ` Johannes Schindelin
2012-11-30 18:27 ` Jeff King
2012-11-13 14:04 ` Erik Faye-Lund [this message]
2012-11-30 18:06 ` [PATCH/RFC 5/5] mingw: get rid of getpass implementation Johannes Schindelin
2012-11-30 18:27 ` Jeff King
2012-11-30 10:16 ` [PATCH/RFC 0/5] win32: support echo for terminal-prompt Erik Faye-Lund
2012-11-30 18:30 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352815447-8824-6-git-send-email-kusmabite@gmail.com \
--to=kusmabite@gmail.com \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).