From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH v3 1/6] completion: add comment for test_completion()
Date: Sun, 18 Nov 2012 11:51:52 +0100 [thread overview]
Message-ID: <1353235917-13059-2-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1353235917-13059-1-git-send-email-felipe.contreras@gmail.com>
So that it's easier to understand what it does.
Also, make sure we pass only the first argument for completion.
Shouldn't cause any functional changes because run_completion only
checks $1.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
t/t9902-completion.sh | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index 8fa025f..2276a37 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -54,10 +54,14 @@ run_completion ()
__git_wrap__git_main && print_comp
}
+# Test high-level completion
+# Arguments are:
+# 1: current command line
+# 2: expected completion
test_completion ()
{
test $# -gt 1 && echo "$2" > expected
- run_completion "$@" &&
+ run_completion "$1" &&
test_cmp expected out
}
--
1.8.0
next prev parent reply other threads:[~2012-11-18 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 10:51 [PATCH v3 0/6] completion: test consolidations Felipe Contreras
2012-11-18 10:51 ` Felipe Contreras [this message]
2012-11-18 10:51 ` [PATCH v3 2/6] completion: standardize final space marker in tests Felipe Contreras
2012-11-18 10:51 ` [PATCH v3 3/6] completion: simplify tests using test_completion_long() Felipe Contreras
2012-11-18 10:51 ` [PATCH v3 4/6] completion: consolidate test_completion*() tests Felipe Contreras
2012-11-18 10:51 ` [PATCH v3 5/6] completion: refactor __gitcomp related tests Felipe Contreras
2012-11-18 10:51 ` [PATCH v3 6/6] completion: simplify __gitcomp() test helper Felipe Contreras
2012-11-19 20:34 ` [PATCH v3 0/6] completion: test consolidations Junio C Hamano
2012-11-19 22:58 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353235917-13059-2-git-send-email-felipe.contreras@gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).