* [PATCH] Fix typo in remote set-head usage
@ 2012-11-25 13:43 Antoine Pelisse
2012-11-26 18:16 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Antoine Pelisse @ 2012-11-25 13:43 UTC (permalink / raw)
To: git; +Cc: tim.henigan, Antoine Pelisse
parenthesis are not matching in `builtin_remote_sethead_usage`
as a square bracket is closing something never opened.
---
This will also break all translation files, should I also send a patch
to update them ?
Cheers,
Antoine Pelisse
builtin/remote.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/remote.c b/builtin/remote.c
index a5a4b23..937484d 100644
--- a/builtin/remote.c
+++ b/builtin/remote.c
@@ -39,7 +39,7 @@ static const char * const builtin_remote_rm_usage[] = {
};
static const char * const builtin_remote_sethead_usage[] = {
- N_("git remote set-head <name> (-a | -d | <branch>])"),
+ N_("git remote set-head <name> (-a | -d | <branch>)"),
NULL
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fix typo in remote set-head usage
2012-11-25 13:43 [PATCH] Fix typo in remote set-head usage Antoine Pelisse
@ 2012-11-26 18:16 ` Junio C Hamano
2012-11-26 19:21 ` Antoine Pelisse
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2012-11-26 18:16 UTC (permalink / raw)
To: Antoine Pelisse; +Cc: git, tim.henigan, Jiang Xin
Antoine Pelisse <apelisse@gmail.com> writes:
> parenthesis are not matching in `builtin_remote_sethead_usage`
> as a square bracket is closing something never opened.
> ---
> This will also break all translation files, should I also send a patch
> to update them ?
"git grep -A2 -e 'remote set-head <name>' po/" tells me that we
already have both the correct variant and the broken one, and they
are both translated ;-) so I do not think we have much to worry
about the i18n fallout in this case, but thanks anyway for thinking
about it.
You would need to sign off your patch, but otherwise looks good to
me.
Thanks.
>
> Cheers,
> Antoine Pelisse
>
> builtin/remote.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/remote.c b/builtin/remote.c
> index a5a4b23..937484d 100644
> --- a/builtin/remote.c
> +++ b/builtin/remote.c
> @@ -39,7 +39,7 @@ static const char * const builtin_remote_rm_usage[] = {
> };
>
> static const char * const builtin_remote_sethead_usage[] = {
> - N_("git remote set-head <name> (-a | -d | <branch>])"),
> + N_("git remote set-head <name> (-a | -d | <branch>)"),
> NULL
> };
>
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] Fix typo in remote set-head usage
2012-11-26 18:16 ` Junio C Hamano
@ 2012-11-26 19:21 ` Antoine Pelisse
2012-11-26 21:28 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Antoine Pelisse @ 2012-11-26 19:21 UTC (permalink / raw)
To: Junio C Hamano, git; +Cc: Jiang Xin, Antoine Pelisse
parenthesis are not matching in `builtin_remote_sethead_usage`
as a square bracket is closing something never opened.
Signed-off-by: Antoine Pelisse <apelisse@gmail.com>
---
builtin/remote.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/remote.c b/builtin/remote.c
index a5a4b23..937484d 100644
--- a/builtin/remote.c
+++ b/builtin/remote.c
@@ -39,7 +39,7 @@ static const char * const builtin_remote_rm_usage[] = {
};
static const char * const builtin_remote_sethead_usage[] = {
- N_("git remote set-head <name> (-a | -d | <branch>])"),
+ N_("git remote set-head <name> (-a | -d | <branch>)"),
NULL
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-26 21:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-25 13:43 [PATCH] Fix typo in remote set-head usage Antoine Pelisse
2012-11-26 18:16 ` Junio C Hamano
2012-11-26 19:21 ` Antoine Pelisse
2012-11-26 21:28 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).