From: Steffen Prohaska <prohaska@zib.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
"Jan H. Schoenherr" <schnhrr@cs.tu-berlin.de>,
Steffen Prohaska <prohaska@zib.de>
Subject: [PATCH 0/2] Re: [PATCH] shortlog: Fix wrapping lines of wraplen
Date: Tue, 11 Dec 2012 06:59:20 +0100 [thread overview]
Message-ID: <1355205562-23459-1-git-send-email-prohaska@zib.de> (raw)
In-Reply-To: <7v8v97efdv.fsf@alter.siamese.dyndns.org>
On Dec 9, 2012, at 10:36 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Steffen Prohaska <prohaska@zib.de> writes:
>
> > A recent commit [1] fixed a off-by-one wrapping error. As
> > a side-effect, add_wrapped_shortlog_msg() needs to be changed to always
> > append a newline.
>
> Could you clarify "As a side effect" a bit more? Do you mean
> something like this?
See updated patches below.
Steffen
Steffen Prohaska (2):
shortlog: Fix wrapping lines of wraplen (was broken since recent
off-by-one fix)
strbuf_add_wrapped*(): Remove unused return value
builtin/shortlog.c | 5 ++---
t/t4201-shortlog.sh | 24 ++++++++++++++++++++++++
utf8.c | 13 ++++++-------
utf8.h | 4 ++--
4 files changed, 34 insertions(+), 12 deletions(-)
--
1.8.1.rc1.2.gfb98a3a
next prev parent reply other threads:[~2012-12-11 6:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 19:09 [PATCH] shortlog: Fix wrapping lines of wraplen (was broken since recent off-by-one fix) Steffen Prohaska
2012-12-09 9:36 ` [PATCH] shortlog: Fix wrapping lines of wraplen Junio C Hamano
2012-12-11 5:59 ` Steffen Prohaska [this message]
2012-12-11 5:59 ` [PATCH 1/2] shortlog: Fix wrapping lines of wraplen (was broken since recent off-by-one fix) Steffen Prohaska
2012-12-11 10:24 ` "Jan H. Schönherr"
2012-12-11 5:59 ` [PATCH 2/2] strbuf_add_wrapped*(): Remove unused return value Steffen Prohaska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355205562-23459-1-git-send-email-prohaska@zib.de \
--to=prohaska@zib.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=schnhrr@cs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).