From: Jason Holden <jason.k.holden.swdev@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, Jason Holden <jason.k.holden.swdev@gmail.com>
Subject: [PATCH] SubmittingPatches: Document how to request a patch review tag
Date: Fri, 4 Jan 2013 15:58:36 -0500 [thread overview]
Message-ID: <1357333116-6971-1-git-send-email-jason.k.holden.swdev@gmail.com> (raw)
In-Reply-To: <7vy5gb33f9.fsf@alter.siamese.dyndns.org>
Document the preferred way a developer should request to have their
Acked-by/Tested-by/Reviewed-by tag to a patch series under discussion
Signed-off-by: Jason Holden <jason.k.holden.swdev@gmail.com>
---
Junio,
I was ready to add my Reviewed-by to this patch series, but I wasn't sure if
I should email just you the patch author (to cut down on overall list traffic)
or both you and the list. If all reviewed-by/acked-by/tested-by traffic
should go via the email list I think this patch would be helpful, as I
wasn't quite sure how wide of a distribution list to use for my
"Reviewed-by" email.
A very similiar question was asked previously in:
http://thread.gmane.org/gmane.comp.version-control.git/185564/focus=185570
This will apply on top of your last tweak to SubmittingPatches
Please add my reviewed-by to the rest of the patches in this series.
-Jason
Documentation/SubmittingPatches | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index f6276ff..80001c9 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -268,6 +268,11 @@ If you like, you can put extra tags at the end:
4. "Tested-by:" is used to indicate that the person applied the patch
and found it to have the desired effect.
+If you are a reviewer and wish to add your Acked-by/Reviewed-by/Tested-by tag
+to a patch series under discussion (after having reviewed it or tested it
+of course!), reply to the author of the patch series, cc'ing the git mailing
+list.
+
You can also create your own tag or use one that's in common usage
such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:".
--
1.8.1.rc3.28.g0ab5d1f
next prev parent reply other threads:[~2013-01-04 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-01 23:24 [PATCH 0/3] Update SubmittingPatches Junio C Hamano
2013-01-01 23:24 ` [PATCH 1/3] SubmittingPatches: who am I and who cares? Junio C Hamano
2013-01-01 23:24 ` [PATCH 2/3] SubmittingPatches: mention subsystems with dedicated repositories Junio C Hamano
2013-01-02 1:52 ` Jason Holden
2013-01-02 2:14 ` Junio C Hamano
2013-01-02 17:22 ` Junio C Hamano
2013-01-04 20:58 ` Jason Holden [this message]
2013-01-04 21:47 ` [PATCH] SubmittingPatches: Document how to request a patch review tag Junio C Hamano
2013-01-06 7:32 ` Michael Haggerty
2013-01-06 9:01 ` Junio C Hamano
2013-01-01 23:24 ` [PATCH 3/3] SubmittingPatches: remove overlong checklist Junio C Hamano
2013-01-02 9:08 ` [PATCH 0/3] Update SubmittingPatches Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357333116-6971-1-git-send-email-jason.k.holden.swdev@gmail.com \
--to=jason.k.holden.swdev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).