git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bryanlarsen <bryan@larsen.st>
To: git@vger.kernel.org
Subject: Re: bugreport: stgit cannot export empty patch
Date: Thu, 10 Jan 2013 15:16:57 -0800 (PST)	[thread overview]
Message-ID: <1357859817532-7574691.post@n2.nabble.com> (raw)
In-Reply-To: <xmqqboll2nl0.fsf@junio.mtv.corp.google.com>

Junio C Hamano writes:

> Stepan Koltsov &lt;stepan.koltsov@&gt; writes:
>> stgit fails to export empty patches:
>>
>> % stg new empty-patch -m 'asasas'
>> Now at patch "empty-patch"
>> % stg export empty-patch
>> Checking for changes in the working directory ... done
>> fatal: unrecognized input
>> stg export: git failed with code 128
>> zsh: exit 2     stg export empty-patch
>>
>> % stg --version
>> Stacked GIT 0.16-3-g67cf
>> git version 1.7.9.1
>> Python version 2.7.1 (r271:86832, Jul 31 2011, 19:30:53)
>> [GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.15.00)]

> I don't use (or read the sources to) StGIT, but isn't the whole point of
> "stg export" to "convert your StGIT patches into patch files"?  For an
> empty commit, what is an appropriate output?  IOW, is it reasonable to
> have an empty commit in your history if you are planning to "stg export"
> it?

Here's another example where the functionality is useful: 
https://github.com/Hobo/agility-gitorial-patches is used to build
http://cookbook.hobocentral.net/tutorials/agility

Each commit/patch becomes a step in the tutorial.  Some tutorial steps don't
have any code attached to them.

In the past, an export of an empty commit would yield a patch where the last
three lines were

> ---
>  0 files changed, 0 insertions(+), 0 deletions(-)
>

The latest version of stgit along with git v1.6 eliminates the error.  A
bisection identifies cc64b318f26c9e176c4f07b1a459a86e7a04c4eb as the source
of the problem.

Thanks,
Bryan




--
View this message in context: http://git.661346.n2.nabble.com/bugreport-stgit-cannot-export-empty-patch-tp7559494p7574691.html
Sent from the git mailing list archive at Nabble.com.

      parent reply	other threads:[~2013-01-10 23:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 20:57 bugreport: stgit cannot export empty patch Stepan Koltsov
2012-05-18 21:20 ` Junio C Hamano
2012-05-18 22:26   ` Stepan Koltsov
2013-01-10 23:16   ` bryanlarsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357859817532-7574691.post@n2.nabble.com \
    --to=bryan@larsen.st \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).