bugreport: stgit cannot export empty patch

bugreport: stgit cannot export empty patch

[Stepan Koltsov]

Hi.

stgit fails to export empty patches:

% stg new empty-patch -m 'asasas'
Now at patch "empty-patch"
% stg export empty-patch
Checking for changes in the working directory ... done
fatal: unrecognized input
stg export: git failed with code 128
zsh: exit 2     stg export empty-patch

% stg --version
Stacked GIT 0.16-3-g67cf
git version 1.7.9.1
Python version 2.7.1 (r271:86832, Jul 31 2011, 19:30:53)
[GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.15.00)]

-- 
Stepan Koltsov

Re: bugreport: stgit cannot export empty patch

[Junio C Hamano]

Stepan Koltsov <stepan.koltsov@jetbrains.com> writes:

> stgit fails to export empty patches:
>
> % stg new empty-patch -m 'asasas'
> Now at patch "empty-patch"
> % stg export empty-patch
> Checking for changes in the working directory ... done
> fatal: unrecognized input
> stg export: git failed with code 128
> zsh: exit 2     stg export empty-patch
>
> % stg --version
> Stacked GIT 0.16-3-g67cf
> git version 1.7.9.1
> Python version 2.7.1 (r271:86832, Jul 31 2011, 19:30:53)
> [GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.15.00)]

I don't use (or read the sources to) StGIT, but isn't the whole point of
"stg export" to "convert your StGIT patches into patch files"?  For an
empty commit, what is an appropriate output?  IOW, is it reasonable to
have an empty commit in your history if you are planning to "stg export"
it?

Re: bugreport: stgit cannot export empty patch

[Stepan Koltsov]

On Sat, May 19, 2012 at 1:20 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Stepan Koltsov <stepan.koltsov@jetbrains.com> writes:
>
>> stgit fails to export empty patches:
>>
>> % stg new empty-patch -m 'asasas'
>> Now at patch "empty-patch"
>> % stg export empty-patch
>> Checking for changes in the working directory ... done
>> fatal: unrecognized input
>> stg export: git failed with code 128
>> zsh: exit 2     stg export empty-patch
>>
>> % stg --version
>> Stacked GIT 0.16-3-g67cf
>> git version 1.7.9.1
>> Python version 2.7.1 (r271:86832, Jul 31 2011, 19:30:53)
>> [GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.15.00)]
>
> I don't use (or read the sources to) StGIT, but isn't the whole point of
> "stg export" to "convert your StGIT patches into patch files"?  For an
> empty commit, what is an appropriate output?  IOW, is it reasonable to
> have an empty commit in your history if you are planning to "stg export"
> it?

I'm executing stg export to back up. If series contains empty patches,
backup fails.

Scenario: I started some work, created new empty patch, but did
nothing, decided to go home, and do backup of the whole series before
leaving. Backup fails.

AFAIU there's no simpler way to backup stg series than executing

% stg export `stg series --noprefix`

-- 
Stepa

Re: bugreport: stgit cannot export empty patch

[bryanlarsen]

Junio C Hamano writes:

> Stepan Koltsov <stepan.koltsov@> writes:
>> stgit fails to export empty patches:
>>
>> % stg new empty-patch -m 'asasas'
>> Now at patch "empty-patch"
>> % stg export empty-patch
>> Checking for changes in the working directory ... done
>> fatal: unrecognized input
>> stg export: git failed with code 128
>> zsh: exit 2     stg export empty-patch
>>
>> % stg --version
>> Stacked GIT 0.16-3-g67cf
>> git version 1.7.9.1
>> Python version 2.7.1 (r271:86832, Jul 31 2011, 19:30:53)
>> [GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.15.00)]

> I don't use (or read the sources to) StGIT, but isn't the whole point of
> "stg export" to "convert your StGIT patches into patch files"?  For an
> empty commit, what is an appropriate output?  IOW, is it reasonable to
> have an empty commit in your history if you are planning to "stg export"
> it?

Here's another example where the functionality is useful: 
https://github.com/Hobo/agility-gitorial-patches is used to build
http://cookbook.hobocentral.net/tutorials/agility

Each commit/patch becomes a step in the tutorial.  Some tutorial steps don't
have any code attached to them.

In the past, an export of an empty commit would yield a patch where the last
three lines were

> ---
>  0 files changed, 0 insertions(+), 0 deletions(-)
>

The latest version of stgit along with git v1.6 eliminates the error.  A
bisection identifies cc64b318f26c9e176c4f07b1a459a86e7a04c4eb as the source
of the problem.

Thanks,
Bryan




--
View this message in context: http://git.661346.n2.nabble.com/bugreport-stgit-cannot-export-empty-patch-tp7559494p7574691.html
Sent from the git mailing list archive at Nabble.com.