From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH v2 04/21] clean: convert to use parse_pathspec
Date: Fri, 11 Jan 2013 18:20:58 +0700 [thread overview]
Message-ID: <1357903275-16804-5-git-send-email-pclouds@gmail.com> (raw)
In-Reply-To: <1357903275-16804-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
builtin/clean.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/builtin/clean.c b/builtin/clean.c
index 69c1cda..788ad8c 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -42,7 +42,7 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
int rm_flags = REMOVE_DIR_KEEP_NESTED_GIT;
struct strbuf directory = STRBUF_INIT;
struct dir_struct dir;
- static const char **pathspec;
+ struct pathspec pathspec;
struct strbuf buf = STRBUF_INIT;
struct string_list exclude_list = STRING_LIST_INIT_NODUP;
const char *qname;
@@ -101,12 +101,12 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
add_exclude(exclude_list.items[i].string, "", 0,
&dir.exclude_list[EXC_CMDL]);
- pathspec = get_pathspec(prefix, argv);
+ parse_pathspec(&pathspec, PATHSPEC_FROMTOP, 0, prefix, argv);
- fill_directory(&dir, pathspec);
+ fill_directory(&dir, pathspec.raw);
- if (pathspec)
- seen = xmalloc(argc > 0 ? argc : 1);
+ if (pathspec.nr)
+ seen = xmalloc(pathspec.nr);
for (i = 0; i < dir.nr; i++) {
struct dir_entry *ent = dir.entries[i];
@@ -141,10 +141,10 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
if (lstat(ent->name, &st))
continue;
- if (pathspec) {
- memset(seen, 0, argc > 0 ? argc : 1);
- matches = match_pathspec(pathspec, ent->name, len,
- 0, seen);
+ if (pathspec.nr) {
+ memset(seen, 0, pathspec.nr);
+ matches = match_pathspec_depth(&pathspec, ent->name, len,
+ 0, seen);
}
if (S_ISDIR(st.st_mode)) {
@@ -169,7 +169,7 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
}
strbuf_reset(&directory);
} else {
- if (pathspec && !matches)
+ if (pathspec.nr && !matches)
continue;
qname = quote_path_relative(ent->name, -1, &buf, prefix);
if (show_only) {
--
1.8.0.rc2.23.g1fb49df
next prev parent reply other threads:[~2013-01-11 11:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 11:20 [PATCH v2 00/21] nd/parse-pathspec reroll Nguyễn Thái Ngọc Duy
2013-01-11 11:20 ` [PATCH v2 01/21] pathspec: save the non-wildcard length part Nguyễn Thái Ngọc Duy
2013-01-11 11:20 ` [PATCH v2 02/21] Add parse_pathspec() that converts cmdline args to struct pathspec Nguyễn Thái Ngọc Duy
2013-01-11 11:20 ` [PATCH v2 03/21] Export parse_pathspec() and convert some get_pathspec() calls Nguyễn Thái Ngọc Duy
2013-01-11 17:56 ` Matt Kraai
2013-01-12 6:00 ` Duy Nguyen
2013-01-11 11:20 ` Nguyễn Thái Ngọc Duy [this message]
2013-01-11 11:20 ` [PATCH v2 05/21] commit: convert to use parse_pathspec Nguyễn Thái Ngọc Duy
2013-01-12 22:54 ` Martin von Zweigbergk
2013-01-11 11:21 ` [PATCH v2 06/21] status: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 07/21] rerere: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 08/21] checkout: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 09/21] rm: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 10/21] ls-files: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 11/21] archive: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 12/21] add: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 13/21] Convert read_cache_preload() to take struct pathspec Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 14/21] Convert unmerge_cache " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 15/21] checkout: convert read_tree_some " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 16/21] Convert report_path_error " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 17/21] Convert refresh_index " Nguyễn Thái Ngọc Duy
2013-01-11 14:19 ` Nguyen Thai Ngoc Duy
2013-01-11 11:21 ` [PATCH v2 18/21] Convert {read,fill}_directory " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 19/21] Convert add_files_to_cache " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 20/21] Convert more init_pathspec() to parse_pathspec() Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 21/21] Rename field "raw" to "_raw" in struct pathspec Nguyễn Thái Ngọc Duy
2013-01-11 14:26 ` [PATCH v2 22/21] Convert the last use of match_pathspec() and remove it Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357903275-16804-5-git-send-email-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).