git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Aguilar <davvid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, John Keeping <john@keeping.me.uk>
Subject: [PATCH 0/7] mergetool-lib improvements for --tool-help
Date: Fri, 25 Jan 2013 01:43:47 -0800	[thread overview]
Message-ID: <1359107034-14606-1-git-send-email-davvid@gmail.com> (raw)

I ran with John's idea and simplified a few more things so
that the --tool-help output shows the correct results.

My final commit is dependent on John's commits but the other two
could be picked up independently since they are general improvements.

This does add a few symlinks to the repo for the sake of simplicity;
I'm not sure if this presents a problem for folks on other platforms.

The replacement of vim with vimdiff and symlinks simplifies things
so that we can later auto-generate the list-of-all-tools for use
by Documentation/.  This was not previously possible due to the
special-case for the vim tools which this series eliminates.

David Aguilar (3):
  mergetools/vim: Remove redundant diff command
  mergetools: Fix difftool/mergetool --tool-help listing for vim
  mergetool--lib: Improve show_tool_help() output

John Keeping (4):
  git-mergetool: move show_tool_help to mergetool--lib
  git-mergetool: remove redundant assignment
  git-mergetool: don't hardcode 'mergetool' in show_tool_help
  git-difftool: use git-mergetool--lib for "--tool-help"

 git-difftool.perl           | 55 +++++----------------------------------
 git-mergetool--lib.sh       | 63 +++++++++++++++++++++++++++++++++++++++------
 git-mergetool.sh            | 37 --------------------------
 mergetools/gvimdiff         |  1 +
 mergetools/gvimdiff2        |  1 +
 mergetools/{vim => vimdiff} | 12 ++-------
 mergetools/vimdiff2         |  1 +
 7 files changed, 67 insertions(+), 103 deletions(-)
 create mode 120000 mergetools/gvimdiff
 create mode 120000 mergetools/gvimdiff2
 rename mergetools/{vim => vimdiff} (68%)
 create mode 120000 mergetools/vimdiff2

-- 
1.8.1.1.367.g22b1720.dirty

             reply	other threads:[~2013-01-25  9:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-25  9:43 David Aguilar [this message]
2013-01-25  9:43 ` [PATCH 1/7] git-mergetool: move show_tool_help to mergetool--lib David Aguilar
2013-01-25  9:43 ` [PATCH 2/7] git-mergetool: remove redundant assignment David Aguilar
2013-01-25  9:43 ` [PATCH 3/7] git-mergetool: don't hardcode 'mergetool' in show_tool_help David Aguilar
2013-01-25  9:43 ` [PATCH 4/7] git-difftool: use git-mergetool--lib for "--tool-help" David Aguilar
2013-01-25  9:43 ` [PATCH 5/7] mergetools/vim: Remove redundant diff command David Aguilar
2013-01-25  9:43 ` [PATCH 6/7] mergetools: Fix difftool/mergetool --tool-help listing for vim David Aguilar
2013-01-25 10:23   ` Sebastian Schuberth
2013-01-25 10:28     ` David Aguilar
2013-01-25 10:34       ` Sebastian Schuberth
2013-01-25 11:39         ` Sebastian Schuberth
2013-01-25 10:38   ` John Keeping
2013-01-25 10:40     ` David Aguilar
2013-01-25 19:11       ` Junio C Hamano
2013-01-25  9:43 ` [PATCH 7/7] mergetool--lib: Improve show_tool_help() output David Aguilar
2013-01-25 19:54   ` John Keeping
2013-01-25 20:06     ` Junio C Hamano
2013-01-25 20:08     ` John Keeping
2013-01-25 20:16       ` Junio C Hamano
2013-01-25 20:46         ` John Keeping
2013-01-25 20:56           ` Junio C Hamano
2013-01-25 21:16             ` John Keeping
2013-01-25 21:47               ` Junio C Hamano
2013-01-25 22:02                 ` John Keeping
2013-01-25 22:03                   ` [PATCH 8/7] mergetool--lib: don't call "exit" in setup_tool John Keeping
2013-01-26  0:24                     ` Junio C Hamano
2013-01-26  7:01                       ` David Aguilar
2013-01-26 12:17                       ` [PATCH 1/2 v2] " John Keeping
2013-01-26 13:50                         ` [PATCH 1/2 v3] " John Keeping
2013-01-25 22:04                   ` [PATCH 9/7] mergetool--lib: fix path lookup in guess_merge_tool John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359107034-14606-1-git-send-email-davvid@gmail.com \
    --to=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=john@keeping.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).