git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrej E Baranov <admin@andrej-andb.ru>
To: git@vger.kernel.org
Cc: gitster@pobox.com, jrnieder@gmail.com,
	giuseppe.bilotta@gmail.com, jnareb@gmail.com,
	Andrej E Baranov <admin@andrej-andb.ru>
Subject: [PATCH] The images from picon and gravatar are always used over http://, and browsers give mixed contents warning when gitweb is served over https://.
Date: Tue, 29 Jan 2013 00:41:32 +0100	[thread overview]
Message-ID: <1359416492-8597-1-git-send-email-admin@andrej-andb.ru> (raw)

Just drop the scheme: part from the URL, so that these
external sites are accessed over https:// in such a case.

Signed-off-by: Andrej E Baranov <admin@andrej-andb.ru>
---
 gitweb/gitweb.perl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c6bafe6..1309196 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2068,7 +2068,7 @@ sub picon_url {
 	if (!$avatar_cache{$email}) {
 		my ($user, $domain) = split('@', $email);
 		$avatar_cache{$email} =
-			"http://www.cs.indiana.edu/cgi-pub/kinzler/piconsearch.cgi/" .
+			"//www.cs.indiana.edu/cgi-pub/kinzler/piconsearch.cgi/" .
 			"$domain/$user/" .
 			"users+domains+unknown/up/single";
 	}
@@ -2083,7 +2083,7 @@ sub gravatar_url {
 	my $email = lc shift;
 	my $size = shift;
 	$avatar_cache{$email} ||=
-		"http://www.gravatar.com/avatar/" .
+		"//www.gravatar.com/avatar/" .
 			Digest::MD5::md5_hex($email) . "?s=";
 	return $avatar_cache{$email} . $size;
 }
-- 
1.8.1.1

             reply	other threads:[~2013-01-28 23:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-28 23:41 Andrej E Baranov [this message]
2013-01-29  3:03 ` [PATCH] The images from picon and gravatar are always used over http://, and browsers give mixed contents warning when gitweb is served over https:// Junio C Hamano
2013-01-29  3:28   ` Bryan Turner
2013-01-29  4:12     ` Jonathan Nieder
2013-01-29  4:16       ` Bryan Turner
2013-01-29 18:33       ` Junio C Hamano
2013-01-31  1:28         ` Jonathan Nieder
2013-02-01  0:58           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359416492-8597-1-git-send-email-admin@andrej-andb.ru \
    --to=admin@andrej-andb.ru \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=giuseppe.bilotta@gmail.com \
    --cc=jnareb@gmail.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).