From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Heiko Voigt <hvoigt@hvoigt.net>,
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Subject: [PATCH 0/3] rebasing changes that update submodules
Date: Thu, 31 Jan 2013 20:32:02 -0800 [thread overview]
Message-ID: <1359693125-22357-1-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <20130130224904.GB1053@book.hvoigt.net>
"git rebase" used to use "format-patch --full-index" to generate a
series of patches and let "git am --rebase" reconstruct a fake
preimage tree by reading the object names from the "index" lines.
With a230949 (am --rebasing: get patch body from commit, not from
mailbox, 2012-06-26), we switched to use "diff-tree", but forgot
that without "--full-index", the information generated on the
"index" line is insufficient to recreate a preimage tree that
contains a submodule.
The first one is the real fix to this issue.
The other two falls into the niceties category; they are to issue a
better error messge when the machinery is fed an abbreviated object
name on the "index" line for a submodule.
Junio C Hamano (3):
git-am: record full index line in the patch used while rebasing
apply: simplify build_fake_ancestor()
apply: diagnose incomplete submodule object name better
builtin/apply.c | 30 ++++++++++++++++--------------
git-am.sh | 2 +-
t/t7402-submodule-rebase.sh | 30 ++++++++++++++++++++++++++++--
3 files changed, 45 insertions(+), 17 deletions(-)
--
1.8.1.2.612.g09f4be5
next prev parent reply other threads:[~2013-02-01 4:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 18:43 "sha1 information is lacking or useless" when rebasing with a submodule pointer conflict Michael Sims
2013-01-30 21:56 ` Heiko Voigt
2013-01-30 22:49 ` Heiko Voigt
2013-01-30 23:39 ` Junio C Hamano
2013-02-01 4:01 ` Junio C Hamano
2013-02-01 4:32 ` Junio C Hamano [this message]
2013-02-01 4:32 ` [PATCH 1/3] git-am: record full index line in the patch used while rebasing Junio C Hamano
2013-02-01 6:25 ` Martin von Zweigbergk
2013-02-01 4:32 ` [PATCH 2/3] apply: simplify build_fake_ancestor() Junio C Hamano
2013-02-01 4:32 ` [PATCH 3/3] apply: diagnose incomplete submodule object name better Junio C Hamano
2013-02-05 19:19 ` Re* " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359693125-22357-1-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=martin.von.zweigbergk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).