From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlos =?ISO-8859-1?Q?Mart=EDn?= Nieto Subject: Re: Possible regression in ref advertisement Date: Mon, 25 Feb 2013 20:18:36 +0100 Message-ID: <1361819916.24515.5.camel@centaur.cmartin.tk> References: <1361811516.3212.14.camel@centaur.cmartin.tk> <7vvc9gxn2y.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org, peff@peff.net To: Junio C Hamano X-From: git-owner@vger.kernel.org Mon Feb 25 20:18:48 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UA3ZW-0004F0-Cz for gcvg-git-2@plane.gmane.org; Mon, 25 Feb 2013 20:18:46 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758947Ab3BYTSV convert rfc822-to-quoted-printable (ORCPT ); Mon, 25 Feb 2013 14:18:21 -0500 Received: from hessy.cmartin.tk ([78.47.67.53]:54662 "EHLO hessy.dwim.me" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756732Ab3BYTSU (ORCPT ); Mon, 25 Feb 2013 14:18:20 -0500 Received: from [192.168.1.2] (p57A1F6E7.dip.t-dialin.net [87.161.246.231]) by hessy.dwim.me (Postfix) with ESMTPSA id 47A9880616; Mon, 25 Feb 2013 20:18:17 +0100 (CET) In-Reply-To: <7vvc9gxn2y.fsf@alter.siamese.dyndns.org> X-Mailer: Evolution 3.4.4 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Mon, 2013-02-25 at 10:31 -0800, Junio C Hamano wrote: > Carlos Mart=C3=ADn Nieto writes: >=20 > > Hi all, > > > > When testing to see if a different implementation was in shape, I c= ame > > across something odd where newer git doesn't advertise one of the r= efs > > in the git repo. > > > > Running `git ls-remote .` or `git-upload-pack` in my git repo, newe= r git > > versions omit peeling the v1.8.0-rc3 tag. > > > > The diff between the command above when ran with 1.7.10.4 (from Deb= ian) > > and current 'master' > > > > --- old 2013-02-25 17:31:29.583526606 +0100 > > +++ new 2013-02-25 17:31:36.783526559 +0100 > > @@ -1379,7 +1379,6 @@ > > c15295d7477ccec489953299bd03a8e62f86e611 refs/tags/v1.8.0-rc= 2 > > cd46259ebf2e624bcee2aaae05c36663d414e1a2 refs/tags/v1.8.0-rc= 2^{} > > 22ed067acc84eac8a0a72d20478a18aee4e25571 refs/tags/v1.8.0-rc= 3 > > -87a5461fa7b30f7b7baf27204f10219d61500fbf refs/tags/v1.8.0-rc= 3^{} > > bfeb8b9ae0012cb61e026cbcd29664876abf5389 refs/tags/v1.8.0.1 > > ed9fe755130891fc878bb2433204faffb534697b refs/tags/v1.8.0.1^= {} > > 63add1fb45e1ab7a76bb38bbb9467c91fdfaaa7e refs/tags/v1.8.0.2 > > > > Diffing with the output from next, diff tells me it's binary for so= me > > reason, but looking manually, the peeled v1.8.0-rc3 tag isn't there > > either. I haven't had time to bisect this, so I'm putting it out th= ere > > in case anybody wants to investigate before I have time to dig into= it. >=20 > Interesting. "git ls-remote . | grep 1.8.0-" for maint, master, > next and pu produce identical results for me, all showing peeled > ones correctly. Bisection leads me to Peff's 435c8332 (2012-10-04; upload-pack: use peel_ref for ref advertisements) and reverting that commit brings the -rc3^{} back. cmn