From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pete Wyckoff Subject: [PATCH v2 2/3] git p4 test: should honor symlink in p4 client root Date: Mon, 11 Mar 2013 17:45:28 -0400 Message-ID: <1363038329-20185-3-git-send-email-pw@padd.com> References: <5139883C.6080308@viscovery.net> <1363038329-20185-1-git-send-email-pw@padd.com> Cc: =?UTF-8?q?Mikl=C3=B3s=20Fazekas?= , John Keeping , Johannes Sixt To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Mar 11 22:46:41 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UFAYK-0003DD-0g for gcvg-git-2@plane.gmane.org; Mon, 11 Mar 2013 22:46:40 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754589Ab3CKVqN (ORCPT ); Mon, 11 Mar 2013 17:46:13 -0400 Received: from honk.padd.com ([74.3.171.149]:40830 "EHLO honk.padd.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754370Ab3CKVqM (ORCPT ); Mon, 11 Mar 2013 17:46:12 -0400 Received: from arf.padd.com (unknown [50.55.138.130]) by honk.padd.com (Postfix) with ESMTPSA id B736E3362; Mon, 11 Mar 2013 14:46:11 -0700 (PDT) Received: by arf.padd.com (Postfix, from userid 7770) id B7F2A2261E; Mon, 11 Mar 2013 17:46:09 -0400 (EDT) X-Mailer: git-send-email 1.8.2.rc2.65.g92f3e2d In-Reply-To: <1363038329-20185-1-git-send-email-pw@padd.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: This test fails when the p4 client root includes a symlink. It complains: Path /vol/bar/projects/foo/... is not under client root /p/foo and dumps a traceback. Signed-off-by: Pete Wyckoff --- t/t9808-git-p4-chdir.sh | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/t/t9808-git-p4-chdir.sh b/t/t9808-git-p4-chdir.sh index 55c5e36..4773296 100755 --- a/t/t9808-git-p4-chdir.sh +++ b/t/t9808-git-p4-chdir.sh @@ -56,6 +56,33 @@ test_expect_success 'p4 client root would be relative due to clone --dest' ' ) ' +# When the p4 client Root is a symlink, make sure chdir() does not use +# getcwd() to convert it to a physical path. +test_expect_failure SYMLINKS 'p4 client root symlink should stay symbolic' ' + physical="$TRASH_DIRECTORY/physical" && + symbolic="$TRASH_DIRECTORY/symbolic" && + test_when_finished "rm -rf \"$physical\"" && + test_when_finished "rm \"$symbolic\"" && + mkdir -p "$physical" && + ln -s "$physical" "$symbolic" && + test_when_finished cleanup_git && + ( + P4CLIENT=client-sym && + p4 client -i <<-EOF && + Client: $P4CLIENT + Description: $P4CLIENT + Root: $symbolic + LineEnd: unix + View: //depot/... //$P4CLIENT/... + EOF + git p4 clone --dest="$git" //depot && + cd "$git" && + test_commit file2 && + git config git-p4.skipSubmitEdit true && + git p4 submit + ) +' + test_expect_success 'kill p4d' ' kill_p4d ' -- 1.8.2.rc2.65.g92f3e2d