git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jérémy Rosen" <jeremy.rosen@openwide.fr>
To: git@vger.kernel.org
Cc: greened@obbligato.org, pcampbell@kemitix.net, gitster@pobox.com,
	"Jérémy Rosen" <jeremy.rosen@openwide.fr>
Subject: [PATCH 1/2] git-subtree: make sure the SHA saved as ancestor is a commit
Date: Wed, 13 Mar 2013 17:17:31 +0100	[thread overview]
Message-ID: <1363191452-28804-2-git-send-email-jeremy.rosen@openwide.fr> (raw)
In-Reply-To: <1363191452-28804-1-git-send-email-jeremy.rosen@openwide.fr>

When adding or merging the first parameter might not be a commit, it can also be a tag SHA.
This needs to be fixed by using the underlying commit or the ancestor finding code will croak at split time


Signed-off-by: Jérémy Rosen <jeremy.rosen@openwide.fr>
---
 contrib/subtree/git-subtree.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh
index 8a23f58..8b9d114 100755
--- a/contrib/subtree/git-subtree.sh
+++ b/contrib/subtree/git-subtree.sh
@@ -531,7 +531,7 @@ cmd_add_repository()
 
 cmd_add_commit()
 {
-	revs=$(git rev-parse $default --revs-only "$@") || exit $?
+	revs=$(git rev-parse $default --revs-only "$1^{commit}") || exit $?
 	set -- $revs
 	rev="$1"
 	
@@ -655,7 +655,7 @@ cmd_split()
 
 cmd_merge()
 {
-	revs=$(git rev-parse $default --revs-only "$@") || exit $?
+	revs=$(git rev-parse $default --revs-only "$1^{commit}") || exit $?
 	ensure_clean
 	
 	set -- $revs
-- 
1.7.10.4

  reply	other threads:[~2013-03-13 16:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 16:17 [PATCH 0/2] git subtree: properly handle remote refs Jérémy Rosen
2013-03-13 16:17 ` Jérémy Rosen [this message]
2013-03-13 16:17 ` [PATCH 2/2] git-subtree: use ls-remote to check the refspec passed to pull and add Jérémy Rosen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363191452-28804-2-git-send-email-jeremy.rosen@openwide.fr \
    --to=jeremy.rosen@openwide.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=greened@obbligato.org \
    --cc=pcampbell@kemitix.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).