git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
	"Max Horn" <max@quendi.de>,
	"Antoine Pelisse" <apelisse@gmail.com>,
	"Torsten Bögershausen" <tboegi@web.de>,
	"Felipe Contreras" <felipe.contreras@gmail.com>
Subject: [PATCH v2 1/4] remote-bzr: avoid echo -n
Date: Thu,  4 Apr 2013 09:36:16 -0600	[thread overview]
Message-ID: <1365089779-9726-2-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1365089779-9726-1-git-send-email-felipe.contreras@gmail.com>

It's not portable, as reported by test-lint.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/remote-helpers/test-bzr.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh
index 70aa8a0..b81052b 100755
--- a/contrib/remote-helpers/test-bzr.sh
+++ b/contrib/remote-helpers/test-bzr.sh
@@ -136,7 +136,7 @@ test_expect_success 'special modes' '
   (cd gitrepo &&
   git cat-file -p HEAD:link > ../actual) &&
 
-  echo -n content > expected &&
+  printf content > expected &&
   test_cmp expected actual
 '
 
-- 
1.8.2

  reply	other threads:[~2013-04-04 15:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04 15:36 [PATCH v2 0/4] remote-helpers: trivial test fixes Felipe Contreras
2013-04-04 15:36 ` Felipe Contreras [this message]
2013-04-04 15:36 ` [PATCH v2 2/4] remote-helpers: fix the run of all tests Felipe Contreras
2013-04-04 15:36 ` [PATCH v2 3/4] remote-bzr: remove stale check code for tests Felipe Contreras
2013-04-04 15:36 ` [PATCH v2 4/4] remote-hg: fix hg-git test-case Felipe Contreras
2013-04-06 17:03 ` [PATCH v2 0/4] remote-helpers: trivial test fixes Torsten Bögershausen
2013-04-06 17:09   ` Torsten Bögershausen
2013-04-06 17:29   ` Felipe Contreras
2013-04-06 17:45     ` Torsten Bögershausen
2013-04-06 17:58       ` Felipe Contreras
2013-04-06 18:41         ` Torsten Bögershausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365089779-9726-2-git-send-email-felipe.contreras@gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=apelisse@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=max@quendi.de \
    --cc=peff@peff.net \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).