From: Lukas Fleischer <git@cryptocrack.de>
To: git@vger.kernel.org
Subject: [PATCH 2/2] t5704: Test prerequisites with empty commit messages
Date: Sun, 7 Apr 2013 13:53:16 +0200 [thread overview]
Message-ID: <1365335596-19917-2-git-send-email-git@cryptocrack.de> (raw)
In-Reply-To: <1365335596-19917-1-git-send-email-git@cryptocrack.de>
While stating that commit messages of prerequisites are optional in
bundles, we used to disallow prerequisite lines consisting of an object
name only. This behavior made `git bundle verify` and `git bundle
unbundle` reject bundles that contain prerequisites without any commit
message.
Add a test to reproduce this behavior.
Signed-off-by: Lukas Fleischer <git@cryptocrack.de>
---
t/t5704-bundle.sh | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/t/t5704-bundle.sh b/t/t5704-bundle.sh
index 9e43731..a45c316 100755
--- a/t/t5704-bundle.sh
+++ b/t/t5704-bundle.sh
@@ -58,4 +58,14 @@ test_expect_success 'ridiculously long subject in boundary' '
grep "^-[0-9a-f]\\{40\\} " boundary
'
+test_expect_success 'prerequisites with an empty commit message' '
+ : >file1 &&
+ git add file1 &&
+ test_tick &&
+ git commit --allow-empty-message -m "" &&
+ test_commit file2 &&
+ git bundle create bundle HEAD^.. &&
+ git bundle verify bundle
+'
+
test_done
--
1.8.2.675.gda3bb24.dirty
next prev parent reply other threads:[~2013-04-07 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 11:53 [PATCH 1/2] bundle: Accept prerequisites without commit messages Lukas Fleischer
2013-04-07 11:53 ` Lukas Fleischer [this message]
2013-04-07 15:24 ` Lukas Fleischer
2013-04-07 17:21 ` Junio C Hamano
2013-04-07 17:29 ` Junio C Hamano
2013-04-08 1:06 ` Jeff King
2013-04-08 9:53 ` Lukas Fleischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365335596-19917-2-git-send-email-git@cryptocrack.de \
--to=git@cryptocrack.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).