* [PATCH 0/5] Minor additions to git-completion.bash
@ 2013-04-21 13:05 Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 1/5] git-completion.bash: lexical sorting for diff.statGraphWidth Ramkumar Ramachandra
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Ramkumar Ramachandra @ 2013-04-21 13:05 UTC (permalink / raw)
To: Git List; +Cc: Felipe Contreras, Junio C Hamano
Hi,
I just looked at the config section, and started writing patches, and
kept going until I got bored. So they're pretty random.
Sorry about the triviality of the patches: I was just looking to kill
some time on a lazy Sunday afternoon.
Thanks.
Ramkumar Ramachandra (5):
git-completion.bash: lexical sorting for diff.statGraphWidth
git-completion.bash: add diff.submodule to config list
git-completion.bash: complete branch.*.rebase as boolean
git-completion.bash: add branch.*.pushremote to config list
git-completion.bash: add remote.pushdefault to config list
contrib/completion/git-completion.bash | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
--
1.8.2.1.501.gd2949c7
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/5] git-completion.bash: lexical sorting for diff.statGraphWidth
2013-04-21 13:05 [PATCH 0/5] Minor additions to git-completion.bash Ramkumar Ramachandra
@ 2013-04-21 13:05 ` Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 2/5] git-completion.bash: add diff.submodule to config list Ramkumar Ramachandra
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Ramkumar Ramachandra @ 2013-04-21 13:05 UTC (permalink / raw)
To: Git List; +Cc: Felipe Contreras, Junio C Hamano
df44483a (diff --stat: add config option to limit graph width,
2012-03-01) added the option diff.startGraphWidth to the list of
configuration variables in git-completion.bash, but failed to notice
that the list is sorted alphabetically. Move it to its rightful place
in the list.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
contrib/completion/git-completion.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 6df62c2..6bfb9ad 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2058,13 +2058,13 @@ _git_config ()
core.whitespace
core.worktree
diff.autorefreshindex
- diff.statGraphWidth
diff.external
diff.ignoreSubmodules
diff.mnemonicprefix
diff.noprefix
diff.renameLimit
diff.renames
+ diff.statGraphWidth
diff.suppressBlankEmpty
diff.tool
diff.wordRegex
--
1.8.2.1.501.gd2949c7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/5] git-completion.bash: add diff.submodule to config list
2013-04-21 13:05 [PATCH 0/5] Minor additions to git-completion.bash Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 1/5] git-completion.bash: lexical sorting for diff.statGraphWidth Ramkumar Ramachandra
@ 2013-04-21 13:05 ` Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 3/5] git-completion.bash: complete branch.*.rebase as boolean Ramkumar Ramachandra
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Ramkumar Ramachandra @ 2013-04-21 13:05 UTC (permalink / raw)
To: Git List; +Cc: Felipe Contreras, Junio C Hamano
c47ef57 (diff: introduce diff.submodule configuration variable,
2012-11-13) introduced the diff.submodule configuration variable, but
forgot to teach git-completion.bash about it. Fix this.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
contrib/completion/git-completion.bash | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 6bfb9ad..f799dc8 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1864,6 +1864,10 @@ _git_config ()
"
return
;;
+ diff.submodule)
+ __gitcomp "log short"
+ return
+ ;;
help.format)
__gitcomp "man info web html"
return
@@ -2065,6 +2069,7 @@ _git_config ()
diff.renameLimit
diff.renames
diff.statGraphWidth
+ diff.submodule
diff.suppressBlankEmpty
diff.tool
diff.wordRegex
--
1.8.2.1.501.gd2949c7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/5] git-completion.bash: complete branch.*.rebase as boolean
2013-04-21 13:05 [PATCH 0/5] Minor additions to git-completion.bash Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 1/5] git-completion.bash: lexical sorting for diff.statGraphWidth Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 2/5] git-completion.bash: add diff.submodule to config list Ramkumar Ramachandra
@ 2013-04-21 13:05 ` Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 4/5] git-completion.bash: add branch.*.pushremote to config list Ramkumar Ramachandra
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Ramkumar Ramachandra @ 2013-04-21 13:05 UTC (permalink / raw)
To: Git List; +Cc: Felipe Contreras, Junio C Hamano
6fac1b83 (completion: add missing config variables, 2009-06-29) added
"rebase" to the list of completions for "branch.*.*", but forgot to
specify completions for the values that this configuration variable
can take (namely "false" and "true"). Fix this.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
contrib/completion/git-completion.bash | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index f799dc8..843273c 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1825,6 +1825,10 @@ _git_config ()
__gitcomp_nl "$(__git_refs)"
return
;;
+ branch.*.rebase)
+ __gitcomp "false true"
+ return
+ ;;
remote.*.fetch)
local remote="${prev#remote.}"
remote="${remote%.fetch}"
--
1.8.2.1.501.gd2949c7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/5] git-completion.bash: add branch.*.pushremote to config list
2013-04-21 13:05 [PATCH 0/5] Minor additions to git-completion.bash Ramkumar Ramachandra
` (2 preceding siblings ...)
2013-04-21 13:05 ` [PATCH 3/5] git-completion.bash: complete branch.*.rebase as boolean Ramkumar Ramachandra
@ 2013-04-21 13:05 ` Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 5/5] git-completion.bash: add remote.pushdefault " Ramkumar Ramachandra
2013-04-24 19:49 ` [PATCH 0/5] Minor additions to git-completion.bash Ramkumar Ramachandra
5 siblings, 0 replies; 11+ messages in thread
From: Ramkumar Ramachandra @ 2013-04-21 13:05 UTC (permalink / raw)
To: Git List; +Cc: Felipe Contreras, Junio C Hamano
9f765ce (remote.c: introduce branch.<name>.pushremote, 2013-04-02)
introduced the configuration variable branch.*.pushremote, but forgot
to teach git-completion.bash about it. Fix this.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
contrib/completion/git-completion.bash | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 843273c..fa0d604 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1817,7 +1817,7 @@ __git_config_get_set_variables ()
_git_config ()
{
case "$prev" in
- branch.*.remote)
+ branch.*.remote|branch.*.pushremote)
__gitcomp_nl "$(__git_remotes)"
return
;;
@@ -1913,7 +1913,7 @@ _git_config ()
;;
branch.*.*)
local pfx="${cur%.*}." cur_="${cur##*.}"
- __gitcomp "remote merge mergeoptions rebase" "$pfx" "$cur_"
+ __gitcomp "remote pushremote merge mergeoptions rebase" "$pfx" "$cur_"
return
;;
branch.*)
--
1.8.2.1.501.gd2949c7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/5] git-completion.bash: add remote.pushdefault to config list
2013-04-21 13:05 [PATCH 0/5] Minor additions to git-completion.bash Ramkumar Ramachandra
` (3 preceding siblings ...)
2013-04-21 13:05 ` [PATCH 4/5] git-completion.bash: add branch.*.pushremote to config list Ramkumar Ramachandra
@ 2013-04-21 13:05 ` Ramkumar Ramachandra
2013-04-24 19:49 ` [PATCH 0/5] Minor additions to git-completion.bash Ramkumar Ramachandra
5 siblings, 0 replies; 11+ messages in thread
From: Ramkumar Ramachandra @ 2013-04-21 13:05 UTC (permalink / raw)
To: Git List; +Cc: Felipe Contreras, Junio C Hamano
224c2171 (remote.c: introduce remote.pushdefault, 2013-04-02)
introduced the remote.pushdefault configuration variable, but forgot
to teach git-completion.bash about it. Fix this.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
contrib/completion/git-completion.bash | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index fa0d604..d0cb4f1 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1829,6 +1829,10 @@ _git_config ()
__gitcomp "false true"
return
;;
+ remote.pushdefault)
+ __gitcomp_nl "$(__git_remotes)"
+ return
+ ;;
remote.*.fetch)
local remote="${prev#remote.}"
remote="${remote%.fetch}"
@@ -2208,6 +2212,7 @@ _git_config ()
receive.fsckObjects
receive.unpackLimit
receive.updateserverinfo
+ remote.pushdefault
remotes.
repack.usedeltabaseoffset
rerere.autoupdate
--
1.8.2.1.501.gd2949c7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] Minor additions to git-completion.bash
2013-04-21 13:05 [PATCH 0/5] Minor additions to git-completion.bash Ramkumar Ramachandra
` (4 preceding siblings ...)
2013-04-21 13:05 ` [PATCH 5/5] git-completion.bash: add remote.pushdefault " Ramkumar Ramachandra
@ 2013-04-24 19:49 ` Ramkumar Ramachandra
2013-04-27 1:57 ` Felipe Contreras
5 siblings, 1 reply; 11+ messages in thread
From: Ramkumar Ramachandra @ 2013-04-24 19:49 UTC (permalink / raw)
To: Git List; +Cc: Felipe Contreras, Junio C Hamano
Ramkumar Ramachandra wrote:
> [...]
Any updates on this?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] Minor additions to git-completion.bash
2013-04-24 19:49 ` [PATCH 0/5] Minor additions to git-completion.bash Ramkumar Ramachandra
@ 2013-04-27 1:57 ` Felipe Contreras
2013-04-28 18:48 ` Junio C Hamano
0 siblings, 1 reply; 11+ messages in thread
From: Felipe Contreras @ 2013-04-27 1:57 UTC (permalink / raw)
To: Ramkumar Ramachandra; +Cc: Git List, Junio C Hamano
On Wed, Apr 24, 2013 at 2:49 PM, Ramkumar Ramachandra
<artagnon@gmail.com> wrote:
> Ramkumar Ramachandra wrote:
>> [...]
>
> Any updates on this?
FWIW they all look OK to me.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] Minor additions to git-completion.bash
2013-04-27 1:57 ` Felipe Contreras
@ 2013-04-28 18:48 ` Junio C Hamano
2013-04-29 4:58 ` Felipe Contreras
0 siblings, 1 reply; 11+ messages in thread
From: Junio C Hamano @ 2013-04-28 18:48 UTC (permalink / raw)
To: Ramkumar Ramachandra; +Cc: Git List, Felipe Contreras
Felipe Contreras <felipe.contreras@gmail.com> writes:
> On Wed, Apr 24, 2013 at 2:49 PM, Ramkumar Ramachandra
> <artagnon@gmail.com> wrote:
>> Ramkumar Ramachandra wrote:
>>> [...]
>>
>> Any updates on this?
>
> FWIW they all look OK to me.
I do not have the original series, so a resend with Felipe's Acked-by
after your original Sign-off would be nice.
Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] Minor additions to git-completion.bash
2013-04-28 18:48 ` Junio C Hamano
@ 2013-04-29 4:58 ` Felipe Contreras
0 siblings, 0 replies; 11+ messages in thread
From: Felipe Contreras @ 2013-04-29 4:58 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Ramkumar Ramachandra, Git List
On Sun, Apr 28, 2013 at 1:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Wed, Apr 24, 2013 at 2:49 PM, Ramkumar Ramachandra
>> <artagnon@gmail.com> wrote:
>>> Ramkumar Ramachandra wrote:
>>>> [...]
>>>
>>> Any updates on this?
>>
>> FWIW they all look OK to me.
>
> I do not have the original series, so a resend with Felipe's Acked-by
> after your original Sign-off would be nice.
I only gave them a quick look.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 5/5] git-completion.bash: add remote.pushdefault to config list
2013-04-29 12:49 [PATCH 0/5] [RESEND] " Ramkumar Ramachandra
@ 2013-04-29 12:49 ` Ramkumar Ramachandra
0 siblings, 0 replies; 11+ messages in thread
From: Ramkumar Ramachandra @ 2013-04-29 12:49 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Felipe Contreras, Git List
224c2171 (remote.c: introduce remote.pushdefault, 2013-04-02)
introduced the remote.pushdefault configuration variable, but forgot
to teach git-completion.bash about it. Fix this.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
contrib/completion/git-completion.bash | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index af271cc..2bbd8a3 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1822,6 +1822,10 @@ _git_config ()
__gitcomp "false true"
return
;;
+ remote.pushdefault)
+ __gitcomp_nl "$(__git_remotes)"
+ return
+ ;;
remote.*.fetch)
local remote="${prev#remote.}"
remote="${remote%.fetch}"
@@ -2201,6 +2205,7 @@ _git_config ()
receive.fsckObjects
receive.unpackLimit
receive.updateserverinfo
+ remote.pushdefault
remotes.
repack.usedeltabaseoffset
rerere.autoupdate
--
1.8.2.1.616.ga1e5536.dirty
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-04-29 12:48 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-21 13:05 [PATCH 0/5] Minor additions to git-completion.bash Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 1/5] git-completion.bash: lexical sorting for diff.statGraphWidth Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 2/5] git-completion.bash: add diff.submodule to config list Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 3/5] git-completion.bash: complete branch.*.rebase as boolean Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 4/5] git-completion.bash: add branch.*.pushremote to config list Ramkumar Ramachandra
2013-04-21 13:05 ` [PATCH 5/5] git-completion.bash: add remote.pushdefault " Ramkumar Ramachandra
2013-04-24 19:49 ` [PATCH 0/5] Minor additions to git-completion.bash Ramkumar Ramachandra
2013-04-27 1:57 ` Felipe Contreras
2013-04-28 18:48 ` Junio C Hamano
2013-04-29 4:58 ` Felipe Contreras
-- strict thread matches above, loose matches on Subject: below --
2013-04-29 12:49 [PATCH 0/5] [RESEND] " Ramkumar Ramachandra
2013-04-29 12:49 ` [PATCH 5/5] git-completion.bash: add remote.pushdefault to config list Ramkumar Ramachandra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).