From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH v3 1/9] remote-helpers: trivial cleanups
Date: Fri, 26 Apr 2013 16:12:31 -0500 [thread overview]
Message-ID: <1367010759-17928-2-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1367010759-17928-1-git-send-email-felipe.contreras@gmail.com>
No functional changes. Typos, unused variables, redundant operations,
and white-spaces.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
contrib/remote-helpers/git-remote-bzr | 7 ++++---
contrib/remote-helpers/git-remote-hg | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
index cc6609b..87c54bf 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@ -94,7 +94,7 @@ class Marks:
return self.last_mark
def is_marked(self, rev):
- return str(rev) in self.marks
+ return rev in self.marks
def new_mark(self, rev, mark):
self.marks[rev] = mark
@@ -224,7 +224,7 @@ def export_files(tree, files):
else:
mode = '100644'
- # is the blog already exported?
+ # is the blob already exported?
if h in filenodes:
mark = filenodes[h]
final.append((mode, mark, path))
@@ -521,7 +521,7 @@ def c_style_unescape(string):
return string
def parse_commit(parser):
- global marks, blob_marks, bmarks, parsed_refs
+ global marks, blob_marks, parsed_refs
global mode
parents = []
@@ -643,6 +643,7 @@ def do_export(parser):
wt = repo.bzrdir.open_workingtree()
wt.update()
print "ok %s" % ref
+
print
def do_capabilities(parser):
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index fda4199..cfa96c1 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -12,7 +12,7 @@
# For remote repositories a local clone is stored in
# "$GIT_DIR/hg/origin/clone/.hg/".
-from mercurial import hg, ui, bookmarks, context, util, encoding, node, error, extensions
+from mercurial import hg, ui, bookmarks, context, encoding, node, error, extensions
import re
import sys
--
1.8.2.1.1031.g2ee5873
next prev parent reply other threads:[~2013-04-26 21:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 21:12 [PATCH v3 0/9] remote-helpers: fixes and cleanups Felipe Contreras
2013-04-26 21:12 ` Felipe Contreras [this message]
2013-04-26 21:12 ` [PATCH v3 2/9] remote-hg: remove extra check Felipe Contreras
2013-04-26 21:12 ` [PATCH v3 3/9] remote-bzr: fix bad state issue Felipe Contreras
2013-04-26 21:12 ` [PATCH v3 4/9] remote-bzr: add support to push URLs Felipe Contreras
2013-04-26 21:12 ` [PATCH v3 5/9] remote-hg: use hashlib instead of hg sha1 util Felipe Contreras
2013-04-26 21:12 ` [PATCH v3 6/9] remote-bzr: store converted URL Felipe Contreras
2013-04-26 21:12 ` [PATCH v3 7/9] remote-bzr: tell bazaar to be quiet Felipe Contreras
2013-04-26 21:12 ` [PATCH v3 8/9] remote-bzr: strip extra newline Felipe Contreras
2013-04-26 21:12 ` [PATCH v3 9/9] remote-bzr: use proper push method Felipe Contreras
2013-04-26 22:16 ` [PATCH v3 0/9] remote-helpers: fixes and cleanups Junio C Hamano
2013-04-26 22:23 ` Junio C Hamano
2013-04-26 22:40 ` Felipe Contreras
2013-04-26 23:04 ` Junio C Hamano
2013-04-27 2:56 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367010759-17928-2-git-send-email-felipe.contreras@gmail.com \
--to=felipe.contreras@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox