From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Johannes Sixt <j.sixt@viscovery.net>
Subject: [PATCH 2/3] git-remote-testgit: further remove some bashisms
Date: Mon, 29 Apr 2013 10:41:54 -0700 [thread overview]
Message-ID: <1367257315-12009-3-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1367257315-12009-1-git-send-email-gitster@pobox.com>
From: Johannes Sixt <j.sixt@viscovery.net>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
git-remote-testgit | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/git-remote-testgit b/git-remote-testgit
index 643e4ae..b528949 100755
--- a/git-remote-testgit
+++ b/git-remote-testgit
@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/bin/sh
# Copyright (c) 2012 Felipe Contreras
alias=$1
@@ -23,7 +23,6 @@ then
testgitmarks="$dir/testgit.marks"
test -e "$gitmarks" || >"$gitmarks"
test -e "$testgitmarks" || >"$testgitmarks"
- testgitmarks_args=( "--"{import,export}"-marks=$testgitmarks" )
fi
while read line
@@ -69,7 +68,10 @@ do
fi
echo "feature done"
- git fast-export "${testgitmarks_args[@]}" $refs |
+ git fast-export \
+ ${testgitmarks:+"--import-marks=$testgitmarks"} \
+ ${testgitmarks:+"--export-marks=$testgitmarks"} \
+ $refs |
sed -e "s#refs/heads/#${prefix}/heads/#g"
echo "done"
;;
@@ -88,7 +90,10 @@ do
before=$(git for-each-ref --format=' %(refname) %(objectname) ')
- git fast-import "${testgitmarks_args[@]}" --quiet
+ git fast-import \
+ ${testgitmarks:+"--import-marks=$testgitmarks"} \
+ ${testgitmarks:+"--export-marks=$testgitmarks"} \
+ --quiet
# figure out which refs were updated
git for-each-ref --format='%(refname) %(objectname)' |
--
1.8.3-rc0-121-gda9b90f
next prev parent reply other threads:[~2013-04-29 17:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 20:07 What's cooking in git.git (Apr 2013, #07; Mon, 22) Junio C Hamano
2013-04-23 19:31 ` What's cooking in git.git (Apr 2013, #08; Tue, 23) Junio C Hamano
2013-04-24 7:57 ` Johannes Sixt
2013-04-24 8:04 ` Felipe Contreras
2013-04-24 8:30 ` Johannes Sixt
2013-04-25 5:56 ` [PATCH] git-remote-testgit: avoid process substitution Johannes Sixt
2013-04-25 14:57 ` Junio C Hamano
2013-04-25 17:50 ` Felipe Contreras
2013-04-25 18:25 ` Junio C Hamano
2013-04-25 19:24 ` Felipe Contreras
2013-04-25 20:06 ` Junio C Hamano
2013-04-25 20:31 ` Felipe Contreras
2013-04-26 21:56 ` Felipe Contreras
2013-04-26 22:25 ` Junio C Hamano
2013-04-26 22:45 ` Felipe Contreras
2013-04-26 23:26 ` Re* " Junio C Hamano
2013-04-27 19:13 ` Johannes Sixt
2013-04-29 17:36 ` Junio C Hamano
2013-04-29 17:41 ` [PATCH 0/3] De-bashing remote-testgit Junio C Hamano
2013-04-29 17:41 ` [PATCH 1/3] git-remote-testgit: avoid process substitution Junio C Hamano
2013-04-29 17:41 ` Junio C Hamano [this message]
2013-04-29 17:41 ` [PATCH 3/3] git-remote-testgit: build it to run under $SHELL_PATH Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367257315-12009-3-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).