From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 3/3] git-remote-testgit: build it to run under $SHELL_PATH
Date: Mon, 29 Apr 2013 10:41:55 -0700 [thread overview]
Message-ID: <1367257315-12009-4-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1367257315-12009-1-git-send-email-gitster@pobox.com>
Just like all the other shell scripts, replace the shebang line to
make sure it runs under the shell the user specified.
As this no longer depends on bashisms, t5801 does not have to say
bash must be available somewhere on the system.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
.gitignore | 1 +
Makefile | 1 +
git-remote-testgit => git-remote-testgit.sh | 0
t/t5801-remote-helpers.sh | 5 -----
4 files changed, 2 insertions(+), 5 deletions(-)
rename git-remote-testgit => git-remote-testgit.sh (100%)
diff --git a/.gitignore b/.gitignore
index 6669bf0..10aee94 100644
--- a/.gitignore
+++ b/.gitignore
@@ -125,6 +125,7 @@
/git-remote-ftps
/git-remote-fd
/git-remote-ext
+/git-remote-testgit
/git-remote-testpy
/git-remote-testsvn
/git-repack
diff --git a/Makefile b/Makefile
index 0f931a2..5f424a7 100644
--- a/Makefile
+++ b/Makefile
@@ -460,6 +460,7 @@ SCRIPT_SH += git-mergetool.sh
SCRIPT_SH += git-pull.sh
SCRIPT_SH += git-quiltimport.sh
SCRIPT_SH += git-rebase.sh
+SCRIPT_SH += git-remote-testgit.sh
SCRIPT_SH += git-repack.sh
SCRIPT_SH += git-request-pull.sh
SCRIPT_SH += git-stash.sh
diff --git a/git-remote-testgit b/git-remote-testgit.sh
similarity index 100%
rename from git-remote-testgit
rename to git-remote-testgit.sh
diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
index c956abd..0a83db8 100755
--- a/t/t5801-remote-helpers.sh
+++ b/t/t5801-remote-helpers.sh
@@ -7,11 +7,6 @@ test_description='Test remote-helper import and export commands'
. ./test-lib.sh
-if ! type "${BASH-bash}" >/dev/null 2>&1; then
- skip_all='skipping remote-testgit tests, bash not available'
- test_done
-fi
-
compare_refs() {
git --git-dir="$1/.git" rev-parse --verify $2 >expect &&
git --git-dir="$3/.git" rev-parse --verify $4 >actual &&
--
1.8.3-rc0-121-gda9b90f
prev parent reply other threads:[~2013-04-29 17:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 20:07 What's cooking in git.git (Apr 2013, #07; Mon, 22) Junio C Hamano
2013-04-23 19:31 ` What's cooking in git.git (Apr 2013, #08; Tue, 23) Junio C Hamano
2013-04-24 7:57 ` Johannes Sixt
2013-04-24 8:04 ` Felipe Contreras
2013-04-24 8:30 ` Johannes Sixt
2013-04-25 5:56 ` [PATCH] git-remote-testgit: avoid process substitution Johannes Sixt
2013-04-25 14:57 ` Junio C Hamano
2013-04-25 17:50 ` Felipe Contreras
2013-04-25 18:25 ` Junio C Hamano
2013-04-25 19:24 ` Felipe Contreras
2013-04-25 20:06 ` Junio C Hamano
2013-04-25 20:31 ` Felipe Contreras
2013-04-26 21:56 ` Felipe Contreras
2013-04-26 22:25 ` Junio C Hamano
2013-04-26 22:45 ` Felipe Contreras
2013-04-26 23:26 ` Re* " Junio C Hamano
2013-04-27 19:13 ` Johannes Sixt
2013-04-29 17:36 ` Junio C Hamano
2013-04-29 17:41 ` [PATCH 0/3] De-bashing remote-testgit Junio C Hamano
2013-04-29 17:41 ` [PATCH 1/3] git-remote-testgit: avoid process substitution Junio C Hamano
2013-04-29 17:41 ` [PATCH 2/3] git-remote-testgit: further remove some bashisms Junio C Hamano
2013-04-29 17:41 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367257315-12009-4-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).