From: David Aguilar <davvid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
Mike McCormack <mike@codeweavers.com>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH] imap-send: eliminate HMAC warnings on OS X 10.8
Date: Fri, 10 May 2013 21:43:26 -0700 [thread overview]
Message-ID: <1368247406-10334-1-git-send-email-davvid@gmail.com> (raw)
Mac OS X Mountain Lion warns that HMAC_Init() and friends are
deprecated. Use CommonCrypto's HMAC to eliminate the warnings.
Signed-off-by: David Aguilar <davvid@gmail.com>
---
This builds upon the patch I sent earlier, so technically it's 2/2
While researching these errors I found this:
http://opensource.apple.com/source/Git/Git-37/src/git/imap-send.c
The approach in this patch is similar in spirit, but simpler since
it avoids pushing #ifdefs into the function bodies.
Makefile | 5 +++++
imap-send.c | 10 ++++++++++
2 files changed, 15 insertions(+)
diff --git a/Makefile b/Makefile
index d8a45b4..7e12999 100644
--- a/Makefile
+++ b/Makefile
@@ -1055,6 +1055,7 @@ ifeq ($(uname_S),Darwin)
endif
endif
COMMON_DIGEST_SHA1 = YesPlease
+ COMMON_DIGEST_HMAC = YesPlease
PTHREAD_LIBS =
endif
@@ -1399,6 +1400,10 @@ else
endif
endif
endif
+
+ifdef COMMON_DIGEST_HMAC
+ BASIC_CFLAGS += -DCOMMON_DIGEST_FOR_HMAC=1
+endif
ifdef NO_PERL_MAKEMAKER
export NO_PERL_MAKEMAKER
endif
diff --git a/imap-send.c b/imap-send.c
index d9bcfb4..1b2e69c 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -29,8 +29,18 @@
#ifdef NO_OPENSSL
typedef void *SSL;
#else
+#ifdef COMMON_DIGEST_FOR_HMAC
+#include <CommonCrypto/CommonHMAC.h>
+#define HMAC_CTX CCHmacContext
+#define HMAC_Init(hmac, key, len, algo) CCHmacInit(hmac, algo, key, len)
+#define HMAC_Update CCHmacUpdate
+#define HMAC_Final(hmac, hash, ptr) CCHmacFinal(hmac, hash)
+#define HMAC_CTX_cleanup
+#define EVP_md5() kCCHmacAlgMD5
+#else
#include <openssl/evp.h>
#include <openssl/hmac.h>
+#endif
#include <openssl/x509v3.h>
#endif
--
1.8.3.rc1.46.g9f9589e
next reply other threads:[~2013-05-11 4:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 4:43 David Aguilar [this message]
2013-05-11 6:27 ` [PATCH] imap-send: eliminate HMAC warnings on OS X 10.8 Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368247406-10334-1-git-send-email-davvid@gmail.com \
--to=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=mike@codeweavers.com \
--cc=mitake@dcl.info.waseda.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).