From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 3/6] stash: simplify option parser for create
Date: Mon, 13 May 2013 18:15:51 +0530 [thread overview]
Message-ID: <1368449154-21882-4-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1368449154-21882-1-git-send-email-artagnon@gmail.com>
The option parser for create unnecessarily checks "$1" inside a case
statement that matches "$1" in the first place. Also, use "$@", not
"$*", as our caller is expecting "$1" "$2", not "$1c$2" (where c is the
first character of IFS).
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
git-stash.sh | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/git-stash.sh b/git-stash.sh
index bbefdf6..0ede313 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -546,11 +546,8 @@ clear)
clear_stash "$@"
;;
create)
- if test $# -gt 0 && test "$1" = create
- then
- shift
- fi
- create_stash "$*" && echo "$w_commit"
+ shift
+ create_stash "$@" && echo "$w_commit"
;;
drop)
shift
--
1.8.3.rc1.57.g4ac1522
next prev parent reply other threads:[~2013-05-13 12:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 12:45 [PATCH 0/6] Get stash to help rebase.autostash Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 1/6] Documentation/stash: correct synopsis for create Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 2/6] Documentation/stash: document short form -p in synopsis Ramkumar Ramachandra
2013-05-13 12:45 ` Ramkumar Ramachandra [this message]
2013-05-13 14:34 ` [PATCH 3/6] stash: simplify option parser for create Junio C Hamano
2013-05-13 14:59 ` Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 4/6] stash: introduce 'git stash store' Ramkumar Ramachandra
2013-05-13 14:40 ` Junio C Hamano
2013-05-13 15:02 ` Ramkumar Ramachandra
2013-05-13 15:49 ` Junio C Hamano
2013-05-13 17:15 ` Ramkumar Ramachandra
2013-05-13 17:29 ` Junio C Hamano
2013-05-13 18:09 ` Ramkumar Ramachandra
2013-05-13 18:35 ` Junio C Hamano
2013-05-13 18:45 ` Ramkumar Ramachandra
2013-05-13 19:16 ` Junio C Hamano
2013-05-13 19:25 ` Ramkumar Ramachandra
2013-05-13 18:15 ` Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 5/6] stash: tweak error message in store_stash () Ramkumar Ramachandra
2013-05-13 14:42 ` Junio C Hamano
2013-05-13 12:45 ` [PATCH 6/6] rebase: use 'git stash store' to simplify logic Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368449154-21882-4-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).