From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: [PATCH] for-each-ref: introduce color format
Date: Fri, 17 May 2013 20:25:52 +0530 [thread overview]
Message-ID: <1368802552-16024-1-git-send-email-artagnon@gmail.com> (raw)
You can now do something like
$ git for-each-ref --format='%C(red)%(refname:short)%C(reset)
%C(blue)%(upstream:diff)%C(reset)' --count 5 --sort='-committerdate'
refs/heads
To get output that's much more customizable 'git branch' output. Future
patches will attempt unify the semantics of 'git branch' and 'git
for-each-ref'.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
So my evil plan is to keep extending this format until it's on par
with pretty-formats. Then, we can move towards unifying 'git branch'
and 'git for-each-ref'. This will involve deprecating badly
thought-out options like '-v', and replacing it with the more
powerful '--format'.
I just have one major doubt: in the above output, how do I align all
the upstream branches to the same column? How can I achieve it with
pretty-formats? Something like %*d? But * is already taken to mean
deref in for-each-ref's --format.
By the way, the main motivation for all this comes from the fact that
git for-each-ref is very nicely written :) Look at how it breaks
everything up into atoms and lazily gets the information it needs to
display.
builtin/for-each-ref.c | 26 ++++++++++++++++++++++----
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index 7f059c3..1563b25 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -9,6 +9,7 @@
#include "quote.h"
#include "parse-options.h"
#include "remote.h"
+#include "color.h"
/* Quoting styles */
#define QUOTE_NONE 0
@@ -155,10 +156,13 @@ static const char *find_next(const char *cp)
while (*cp) {
if (*cp == '%') {
/*
+ * %C( is the start of a color;
* %( is the start of an atom;
* %% is a quoted per-cent.
*/
- if (cp[1] == '(')
+ if (cp[1] == 'C' && cp[2] == '(')
+ return cp;
+ else if (cp[1] == '(')
return cp;
else if (cp[1] == '%')
cp++; /* skip over two % */
@@ -180,8 +184,12 @@ static int verify_format(const char *format)
const char *ep = strchr(sp, ')');
if (!ep)
return error("malformed format string %s", sp);
- /* sp points at "%(" and ep points at the closing ")" */
- parse_atom(sp + 2, ep);
+ /*
+ * Ignore color specifications: %C(
+ * sp points at "%(" and ep points at the closing ")"
+ */
+ if (prefixcmp(sp, "%C("))
+ parse_atom(sp + 2, ep);
cp = ep + 1;
}
return 0;
@@ -928,12 +936,22 @@ static void emit(const char *cp, const char *ep)
static void show_ref(struct refinfo *info, const char *format, int quote_style)
{
const char *cp, *sp, *ep;
+ char color[COLOR_MAXLEN];
for (cp = format; *cp && (sp = find_next(cp)); cp = ep + 1) {
ep = strchr(sp, ')');
if (cp < sp)
emit(cp, sp);
- print_value(info, parse_atom(sp + 2, ep), quote_style);
+
+ /* Do we have a color specification? */
+ if (!prefixcmp(sp, "%C("))
+ color_parse_mem(sp + 3,
+ ep - sp - 3,
+ "--format ", color);
+ else {
+ printf("%s", color);
+ print_value(info, parse_atom(sp + 2, ep), quote_style);
+ }
}
if (*cp) {
sp = cp + strlen(cp);
--
1.8.3.rc2.13.g629b60a.dirty
next reply other threads:[~2013-05-17 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 14:55 Ramkumar Ramachandra [this message]
2013-05-17 17:20 ` [PATCH] for-each-ref: introduce color format Junio C Hamano
2013-05-17 17:23 ` Ramkumar Ramachandra
2013-05-19 12:05 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368802552-16024-1-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).