From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH 7/9] for-each-ref: prepoplulate all atoms before show_ref()
Date: Sun, 19 May 2013 17:27:13 +0700 [thread overview]
Message-ID: <1368959235-27777-8-git-send-email-pclouds@gmail.com> (raw)
In-Reply-To: <1368959235-27777-1-git-send-email-pclouds@gmail.com>
By the time show_ref() is called, atom values for all refs are
ready. This can be taken advantage of later.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
builtin/for-each-ref.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index db5c211..a9d189c 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -1010,15 +1010,24 @@ static void show_ref(struct strbuf *sb, struct refinfo *info,
static void show_refs(struct refinfo **refs, int maxcount,
const char *format, int quote_style)
{
- struct strbuf sb = STRBUF_INIT;
+ struct strbuf *sb;
int i;
+ sb = xmalloc(sizeof(*sb) * maxcount);
for (i = 0; i < maxcount; i++) {
- strbuf_reset(&sb);
- show_ref(&sb, refs[i], format, quote_style);
- fputs(sb.buf, stdout);
+ strbuf_init(sb + i, 256);
+ if (!refs[i]->value) {
+ populate_value(refs[i]);
+ fill_missing_values(refs[i]->value);
+ }
+ }
+
+ for (i = 0; i < maxcount; i++) {
+ show_ref(sb + i, refs[i], format, quote_style);
+ fputs(sb[i].buf, stdout);
+ strbuf_release(sb + i);
}
- strbuf_release(&sb);
+ free(sb);
}
static struct ref_sort *default_sort(void)
--
1.8.2.83.gc99314b
next prev parent reply other threads:[~2013-05-19 10:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-19 10:27 [PATCH/WIP 0/9] for-each-ref format improvements Nguyễn Thái Ngọc Duy
2013-05-19 10:27 ` [PATCH 1/9] quote.c: make sq_quote_print a slight wrapper of sq_quote_buf Nguyễn Thái Ngọc Duy
2013-05-19 11:39 ` Felipe Contreras
2013-05-19 10:27 ` [PATCH 2/9] for-each-ref: convert to use *_quote_buf instead of _quote_print Nguyễn Thái Ngọc Duy
2013-05-19 11:39 ` Felipe Contreras
2013-05-19 10:27 ` [PATCH 3/9] for-each-ref: avoid printing each element directly to stdout Nguyễn Thái Ngọc Duy
2013-05-19 11:17 ` Ramkumar Ramachandra
2013-05-19 11:58 ` Duy Nguyen
2013-05-19 10:27 ` [PATCH 4/9] for-each-ref: add %(current) for current branch marker Nguyễn Thái Ngọc Duy
2013-05-19 11:14 ` Ramkumar Ramachandra
2013-05-19 10:27 ` [PATCH 5/9] for-each-ref: add %(tracking[:upstream]) for tracking info Nguyễn Thái Ngọc Duy
2013-05-19 11:18 ` Ramkumar Ramachandra
2013-05-19 11:38 ` Felipe Contreras
2013-05-19 11:43 ` Duy Nguyen
2013-05-19 11:48 ` Ramkumar Ramachandra
2013-05-19 12:03 ` Felipe Contreras
2013-05-19 10:27 ` [PATCH 6/9] for-each-ref: add %(color:...) Nguyễn Thái Ngọc Duy
2013-05-19 11:25 ` Ramkumar Ramachandra
2013-05-19 10:27 ` Nguyễn Thái Ngọc Duy [this message]
2013-05-19 10:27 ` [PATCH 8/9] for-each-ref: merge show_ref into show_refs Nguyễn Thái Ngọc Duy
2013-05-19 10:27 ` [PATCH 9/9] for-each-ref: support %(...:aligned) for left alignment Nguyễn Thái Ngọc Duy
2013-05-19 11:32 ` Ramkumar Ramachandra
2013-05-19 11:41 ` Duy Nguyen
2013-05-19 11:11 ` [PATCH/WIP 0/9] for-each-ref format improvements Ramkumar Ramachandra
2013-05-19 11:36 ` Felipe Contreras
2013-05-19 11:54 ` Duy Nguyen
2013-05-19 12:08 ` Ramkumar Ramachandra
2013-05-19 12:28 ` Duy Nguyen
2013-05-19 13:07 ` Ramkumar Ramachandra
2013-05-20 4:29 ` Junio C Hamano
2013-05-21 17:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368959235-27777-8-git-send-email-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).