From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/2] Fix invalid revision error messages
Date: Wed, 22 May 2013 16:09:53 +0530 [thread overview]
Message-ID: <1369219195-20096-1-git-send-email-artagnon@gmail.com> (raw)
As Junio pointed out in [0/2], this is not for 1.8.3; it's just a
regular "enhacement".
In [1/2], I've extended the commit message with the justification I
wrote out for Junio.
In [2/2], I've made sure to print the "correct" error message
everytime: I missed the detached HEAD case last time. I'm not in
favor of anything "prettier", as I already explained in my email.
Thanks.
Ramkumar Ramachandra (2):
sha1_name: fix error message for @{u}
sha1_name: fix error message for @{<N>}, @{<date>}
sha1_name.c | 23 +++++++++++++++++------
t/t1507-rev-parse-upstream.sh | 15 +++++----------
2 files changed, 22 insertions(+), 16 deletions(-)
--
1.8.3.rc3.10.g6f8d616
next reply other threads:[~2013-05-22 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 10:39 Ramkumar Ramachandra [this message]
2013-05-22 10:39 ` [PATCH 1/2] sha1_name: fix error message for @{u} Ramkumar Ramachandra
2013-05-22 17:35 ` Junio C Hamano
2013-05-23 11:03 ` Ramkumar Ramachandra
2013-05-22 10:39 ` [PATCH 2/2] sha1_name: fix error message for @{<N>}, @{<date>} Ramkumar Ramachandra
2013-05-22 20:39 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369219195-20096-1-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).