From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 6/7] sha1_name: prepare to introduce AT_KIND_PUSH
Date: Thu, 23 May 2013 20:42:49 +0530 [thread overview]
Message-ID: <1369321970-7759-7-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1369321970-7759-1-git-send-email-artagnon@gmail.com>
Introduce an AT_KIND_PUSH to be represented as "@{p[ush]}". Determine
it using branch.remote.push_refspec.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
sha1_name.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/sha1_name.c b/sha1_name.c
index 106716e..5f6958b 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -23,7 +23,7 @@ struct disambiguate_state {
unsigned always_call_fn:1;
};
-#define AT_KIND_UPSTREAM 0
+enum at_kind { AT_KIND_UPSTREAM, AT_KIND_PUSH };
static void update_candidates(struct disambiguate_state *ds, const unsigned char *current)
{
@@ -426,7 +426,8 @@ static inline int at_mark(const char *string, int len, int *kind)
int kind;
const char *suffix[2];
} at_form[] = {
- { AT_KIND_UPSTREAM, { "@{upstream}", "@{u}" } }
+ { AT_KIND_UPSTREAM, { "@{upstream}", "@{u}" } },
+ { AT_KIND_PUSH, { "@{push}", "@{p}" } }
};
for (j = 0; j < ARRAY_SIZE(at_form); j++) {
@@ -1022,6 +1023,12 @@ static void die_no_upstream(struct branch *upstream, char *name) {
* given buf and returns the number of characters parsed if
* successful.
*
+ * - "<branch>@{push}" finds the name of the ref that
+ * <branch> is configured to push to (missing <branch> defaults
+ * to the current branch), and places the name of the branch in the
+ * given buf and returns the number of characters parsed if
+ * successful.
+ *
* If the input is not of the accepted format, it returns a negative
* number to signal an error.
*
@@ -1077,6 +1084,8 @@ int interpret_branch_name(const char *name, struct strbuf *buf)
free(cp);
cp = shorten_unambiguous_ref(branch->merge[0]->dst, 0);
break;
+ case AT_KIND_PUSH:
+ break;
}
strbuf_reset(buf);
--
1.8.3.rc3.17.gd95ec6c.dirty
next prev parent reply other threads:[~2013-05-23 15:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 15:12 [PATCH 0/7] Let's get that @{push}! Ramkumar Ramachandra
2013-05-23 15:12 ` [PATCH 1/7] sha1_name: abstract upstream_mark() logic Ramkumar Ramachandra
2013-05-23 15:12 ` [PATCH 2/7] sha1_name: factor out die_no_upstream() Ramkumar Ramachandra
2013-05-23 15:12 ` [PATCH 3/7] sha1_name: remove upstream_mark() Ramkumar Ramachandra
2013-05-23 15:12 ` [PATCH 4/7] remote: expose parse_push_refspec() Ramkumar Ramachandra
2013-05-23 15:12 ` [PATCH 5/7] remote: expose get_ref_match() Ramkumar Ramachandra
2013-05-23 15:12 ` Ramkumar Ramachandra [this message]
2013-05-24 13:22 ` [PATCH 6/7] sha1_name: prepare to introduce AT_KIND_PUSH Felipe Contreras
2013-05-24 13:27 ` Ramkumar Ramachandra
2013-05-23 15:12 ` [PATCH 7/7] sha1_name: implement finding @{push} Ramkumar Ramachandra
2013-05-24 16:09 ` Duy Nguyen
2013-05-24 16:15 ` Ramkumar Ramachandra
2013-05-24 16:21 ` Duy Nguyen
2013-05-24 16:29 ` Ramkumar Ramachandra
2013-05-24 18:01 ` Junio C Hamano
2013-05-24 18:21 ` Ramkumar Ramachandra
2013-05-24 19:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369321970-7759-7-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).