From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?C=C3=A9lestin=20Matte?= Subject: [PATCH v2 06/22] git-remote-mediawiki: Rewrite unclear line of instructions Date: Fri, 7 Jun 2013 23:42:07 +0200 Message-ID: <1370641344-4253-7-git-send-email-celestin.matte@ensimag.fr> References: <1370641344-4253-1-git-send-email-celestin.matte@ensimag.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: benoit.person@ensimag.fr, matthieu.moy@grenoble-inp.fr, =?UTF-8?q?C=C3=A9lestin=20Matte?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Fri Jun 07 23:43:12 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ul4RC-0007v5-Lq for gcvg-git-2@plane.gmane.org; Fri, 07 Jun 2013 23:43:11 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756518Ab3FGVnH convert rfc822-to-quoted-printable (ORCPT ); Fri, 7 Jun 2013 17:43:07 -0400 Received: from mx1.imag.fr ([129.88.30.5]:51976 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756364Ab3FGVnG (ORCPT ); Fri, 7 Jun 2013 17:43:06 -0400 Received: from ensimag.imag.fr (ensimag.imag.fr [195.221.228.12]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id r57Lh02K026067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 7 Jun 2013 23:43:00 +0200 Received: from ensibm.imag.fr (ensibm.imag.fr [195.221.228.8]) by ensimag.imag.fr (8.13.8/8.13.8/ImagV2.1.r_ens) with ESMTP id r57Lh2ZA029571; Fri, 7 Jun 2013 23:43:02 +0200 Received: from tohwi-K50IE.imag.fr (ensibm [195.221.228.8]) by ensibm.imag.fr (8.13.8/8.13.8/ImagV2.1.sb_ens.pm) with ESMTP id r57LgqRh019409; Fri, 7 Jun 2013 23:43:02 +0200 X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1370641344-4253-1-git-send-email-celestin.matte@ensimag.fr> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Fri, 07 Jun 2013 23:43:00 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: r57Lh02K026067 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: celestin.matte@ensimag.fr MailScanner-NULL-Check: 1371246180.70193@UPX9XEwPAG7fnHkieRV4OA Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Subroutines' parameters should be affected to variable before doing any= thing else Besides, existing instruction affected a variable inside a "if", which = break Git's coding style Signed-off-by: C=C3=A9lestin Matte Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki.perl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-t= o-git/git-remote-mediawiki.perl index 5e348cb..a5c963b 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -1334,7 +1334,8 @@ sub get_mw_namespace_id { } =20 sub get_mw_namespace_id_for_page { - if (my ($namespace) =3D $_[0] =3D~ /^([^:]*):/) { + my $namespace =3D shift; + if ($namespace =3D~ /^([^:]*):/) { return get_mw_namespace_id($namespace); } else { return; --=20 1.7.9.5