From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?C=C3=A9lestin=20Matte?= Subject: [PATCH] git-remote-mediawiki: Fix a bug in a regexp Date: Sat, 8 Jun 2013 15:35:10 +0200 Message-ID: <1370698510-11649-1-git-send-email-celestin.matte@ensimag.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: benoit.person@ensimag.fr, matthieu.moy@grenoble-inp.fr, =?UTF-8?q?C=C3=A9lestin=20Matte?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sat Jun 08 15:35:41 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UlJIz-0003Ph-3s for gcvg-git-2@plane.gmane.org; Sat, 08 Jun 2013 15:35:41 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751585Ab3FHNfh convert rfc822-to-quoted-printable (ORCPT ); Sat, 8 Jun 2013 09:35:37 -0400 Received: from mx2.imag.fr ([129.88.30.17]:35908 "EHLO rominette.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368Ab3FHNfg (ORCPT ); Sat, 8 Jun 2013 09:35:36 -0400 Received: from ensimag.imag.fr (ensimag.imag.fr [195.221.228.12]) by rominette.imag.fr (8.13.8/8.13.8) with ESMTP id r58DZWml007732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 8 Jun 2013 15:35:33 +0200 Received: from ensibm.imag.fr (ensibm.imag.fr [195.221.228.8]) by ensimag.imag.fr (8.13.8/8.13.8/ImagV2.1.r_ens) with ESMTP id r58DZYWk011303; Sat, 8 Jun 2013 15:35:34 +0200 Received: from tohwi-K50IE.imag.fr (ensibm [195.221.228.8]) by ensibm.imag.fr (8.13.8/8.13.8/ImagV2.1.sb_ens.pm) with ESMTP id r58DZY8f020484; Sat, 8 Jun 2013 15:35:34 +0200 X-Mailer: git-send-email 1.7.9.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (rominette.imag.fr [129.88.30.17]); Sat, 08 Jun 2013 15:35:33 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: r58DZWml007732 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: celestin.matte@ensimag.fr MailScanner-NULL-Check: 1371303333.86485@824pYi9suiwoe6hn1b4/Wg Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: In Perl, '\n' is not a newline, but instead a literal backslash followe= d by an "n". As the output of "rev-list --first-parent" is line-oriented, what = we want here is a newline. Signed-off-by: C=C3=A9lestin Matte Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-t= o-git/git-remote-mediawiki.perl index 7af202f..a06bc31 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -1190,7 +1190,7 @@ sub mw_push_revision { # history (linearized with --first-parent) print STDERR "Warning: no common ancestor, pushing complete history\= n"; my $history =3D run_git("rev-list --first-parent --children $local")= ; - my @history =3D split('\n', $history); + my @history =3D split(/\n/, $history); @history =3D @history[1..$#history]; foreach my $line (reverse @history) { my @commit_info_split =3D split(/ |\n/, $line); --=20 1.7.9.5