git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH 16/45] status: convert to use parse_pathspec
Date: Sun,  9 Jun 2013 13:25:49 +0700	[thread overview]
Message-ID: <1370759178-1709-17-git-send-email-pclouds@gmail.com> (raw)
In-Reply-To: <1370759178-1709-1-git-send-email-pclouds@gmail.com>


Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/commit.c |  9 +++++----
 wt-status.c      | 16 +++++++---------
 wt-status.h      |  2 +-
 3 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/builtin/commit.c b/builtin/commit.c
index 0efe269..833c7be 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1197,11 +1197,12 @@ int cmd_status(int argc, const char **argv, const char *prefix)
 	handle_untracked_files_arg(&s);
 	if (show_ignored_in_status)
 		s.show_ignored_files = 1;
-	if (*argv)
-		s.pathspec = get_pathspec(prefix, argv);
+	parse_pathspec(&s.pathspec, 0,
+		       PATHSPEC_PREFER_FULL,
+		       prefix, argv);
 
-	read_cache_preload(s.pathspec);
-	refresh_index(&the_index, REFRESH_QUIET|REFRESH_UNMERGED, s.pathspec, NULL, NULL);
+	read_cache_preload(s.pathspec.raw);
+	refresh_index(&the_index, REFRESH_QUIET|REFRESH_UNMERGED, s.pathspec.raw, NULL, NULL);
 
 	fd = hold_locked_index(&index_lock, 0);
 	if (0 <= fd)
diff --git a/wt-status.c b/wt-status.c
index bf84a86..99302e6 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -1,4 +1,5 @@
 #include "cache.h"
+#include "pathspec.h"
 #include "wt-status.h"
 #include "object.h"
 #include "dir.h"
@@ -437,7 +438,7 @@ static void wt_status_collect_changes_worktree(struct wt_status *s)
 	}
 	rev.diffopt.format_callback = wt_status_collect_changed_cb;
 	rev.diffopt.format_callback_data = s;
-	init_pathspec(&rev.prune_data, s->pathspec);
+	copy_pathspec(&rev.prune_data, &s->pathspec);
 	run_diff_files(&rev, 0);
 }
 
@@ -462,22 +463,20 @@ static void wt_status_collect_changes_index(struct wt_status *s)
 	rev.diffopt.detect_rename = 1;
 	rev.diffopt.rename_limit = 200;
 	rev.diffopt.break_opt = 0;
-	init_pathspec(&rev.prune_data, s->pathspec);
+	copy_pathspec(&rev.prune_data, &s->pathspec);
 	run_diff_index(&rev, 1);
 }
 
 static void wt_status_collect_changes_initial(struct wt_status *s)
 {
-	struct pathspec pathspec;
 	int i;
 
-	init_pathspec(&pathspec, s->pathspec);
 	for (i = 0; i < active_nr; i++) {
 		struct string_list_item *it;
 		struct wt_status_change_data *d;
 		struct cache_entry *ce = active_cache[i];
 
-		if (!ce_path_match(ce, &pathspec))
+		if (!ce_path_match(ce, &s->pathspec))
 			continue;
 		it = string_list_insert(&s->change, ce->name);
 		d = it->util;
@@ -492,7 +491,6 @@ static void wt_status_collect_changes_initial(struct wt_status *s)
 		else
 			d->index_status = DIFF_STATUS_ADDED;
 	}
-	free_pathspec(&pathspec);
 }
 
 static void wt_status_collect_untracked(struct wt_status *s)
@@ -515,12 +513,12 @@ static void wt_status_collect_untracked(struct wt_status *s)
 		dir.flags |= DIR_SHOW_IGNORED_TOO;
 	setup_standard_excludes(&dir);
 
-	fill_directory(&dir, s->pathspec);
+	fill_directory(&dir, s->pathspec.raw);
 
 	for (i = 0; i < dir.nr; i++) {
 		struct dir_entry *ent = dir.entries[i];
 		if (cache_name_is_other(ent->name, ent->len) &&
-		    match_pathspec(s->pathspec, ent->name, ent->len, 0, NULL))
+		    match_pathspec_depth(&s->pathspec, ent->name, ent->len, 0, NULL))
 			string_list_insert(&s->untracked, ent->name);
 		free(ent);
 	}
@@ -528,7 +526,7 @@ static void wt_status_collect_untracked(struct wt_status *s)
 	for (i = 0; i < dir.ignored_nr; i++) {
 		struct dir_entry *ent = dir.ignored[i];
 		if (cache_name_is_other(ent->name, ent->len) &&
-		    match_pathspec(s->pathspec, ent->name, ent->len, 0, NULL))
+		    match_pathspec_depth(&s->pathspec, ent->name, ent->len, 0, NULL))
 			string_list_insert(&s->ignored, ent->name);
 		free(ent);
 	}
diff --git a/wt-status.h b/wt-status.h
index 4121bc2..8463672 100644
--- a/wt-status.h
+++ b/wt-status.h
@@ -44,7 +44,7 @@ struct wt_status {
 	int is_initial;
 	char *branch;
 	const char *reference;
-	const char **pathspec;
+	struct pathspec pathspec;
 	int verbose;
 	int amend;
 	enum commit_whence whence;
-- 
1.8.2.83.gc99314b

  parent reply	other threads:[~2013-06-09  6:26 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-09  6:25 [PATCH 00/45] "struct pathspec" conversion and :(glob) Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 01/45] clean: remove unused variable "seen" Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 02/45] Move struct pathspec and related functions to pathspec.[ch] Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 03/45] pathspec: i18n-ize error strings in pathspec parsing code Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 04/45] pathspec: add copy_pathspec Nguyễn Thái Ngọc Duy
2013-06-09  7:58   ` Eric Sunshine
2013-06-12 18:07     ` Junio C Hamano
2013-06-09  6:25 ` [PATCH 05/45] Add parse_pathspec() that converts cmdline args to struct pathspec Nguyễn Thái Ngọc Duy
2013-06-10  1:24   ` Eric Sunshine
2013-06-09  6:25 ` [PATCH 06/45] parse_pathspec: save original pathspec for reporting Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 07/45] parse_pathspec: add PATHSPEC_PREFER_{CWD,FULL} Nguyễn Thái Ngọc Duy
2013-06-10  1:29   ` Eric Sunshine
2013-06-09  6:25 ` [PATCH 08/45] Convert some get_pathspec() calls to parse_pathspec() Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 09/45] parse_pathspec: a special flag for max_depth feature Nguyễn Thái Ngọc Duy
2013-06-10  1:34   ` Eric Sunshine
2013-06-09  6:25 ` [PATCH 10/45] parse_pathspec: support stripping submodule trailing slashes Nguyễn Thái Ngọc Duy
2013-06-10  1:36   ` Eric Sunshine
2013-06-09  6:25 ` [PATCH 11/45] parse_pathspec: support stripping/checking submodule paths Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 12/45] parse_pathspec: support prefixing original patterns Nguyễn Thái Ngọc Duy
2013-06-10  1:41   ` Eric Sunshine
2013-06-09  6:25 ` [PATCH 13/45] Guard against new pathspec magic in pathspec matching code Nguyễn Thái Ngọc Duy
2013-06-10  1:53   ` Eric Sunshine
2013-06-09  6:25 ` [PATCH 14/45] clean: convert to use parse_pathspec Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 15/45] commit: " Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` Nguyễn Thái Ngọc Duy [this message]
2013-06-09  6:25 ` [PATCH 17/45] rerere: " Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 18/45] checkout: " Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 19/45] rm: " Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 20/45] ls-files: " Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 21/45] archive: " Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 22/45] check-ignore: " Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 23/45] add: " Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 24/45] reset: " Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 25/45] line-log: " Nguyễn Thái Ngọc Duy
2013-06-09  6:25 ` [PATCH 26/45] Convert read_cache_preload() to take struct pathspec Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 27/45] Convert run_add_interactive to use " Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 28/45] Convert unmerge_cache to take " Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 29/45] checkout: convert read_tree_some " Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 30/45] Convert report_path_error " Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 31/45] Convert refresh_index " Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 32/45] Convert {read,fill}_directory " Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 33/45] Convert add_files_to_cache " Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 34/45] Convert common_prefix() to use " Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 35/45] Remove diff_tree_{setup,release}_paths Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 36/45] Remove init_pathspec() in favor of parse_pathspec() Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 37/45] Remove match_pathspec() in favor of match_pathspec_depth() Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 38/45] tree-diff: remove the use of pathspec's raw[] in follow-rename codepath Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 39/45] parse_pathspec: make sure the prefix part is wildcard-free Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 40/45] parse_pathspec: preserve prefix length via PATHSPEC_PREFIX_ORIGIN Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 41/45] Kill limit_pathspec_to_literal() as it's only used by parse_pathspec() Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 42/45] pathspec: support :(literal) syntax for noglob pathspec Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 43/45] pathspec: make --literal-pathspecs disable pathspec magic Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 44/45] pathspec: support :(glob) syntax Nguyễn Thái Ngọc Duy
2013-06-09  6:26 ` [PATCH 45/45] Rename field "raw" to "_raw" in struct pathspec Nguyễn Thái Ngọc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370759178-1709-17-git-send-email-pclouds@gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).