From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?C=C3=A9lestin=20Matte?= Subject: [PATCH v5 14/31] git-remote-mediawiki: Change the name of a variable Date: Wed, 12 Jun 2013 17:43:31 +0200 Message-ID: <1371051828-12866-15-git-send-email-celestin.matte@ensimag.fr> References: <1371051828-12866-1-git-send-email-celestin.matte@ensimag.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: benoit.person@ensimag.fr, matthieu.moy@grenoble-inp.fr, =?UTF-8?q?C=C3=A9lestin=20Matte?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Jun 12 17:45:58 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UmnFF-0008DS-Oc for gcvg-git-2@plane.gmane.org; Wed, 12 Jun 2013 17:45:58 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757204Ab3FLPpq convert rfc822-to-quoted-printable (ORCPT ); Wed, 12 Jun 2013 11:45:46 -0400 Received: from mx1.imag.fr ([129.88.30.5]:43431 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756849Ab3FLPoQ (ORCPT ); Wed, 12 Jun 2013 11:44:16 -0400 Received: from ensimag.imag.fr (ensimag.imag.fr [195.221.228.12]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id r5CFiDSO028704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 Jun 2013 17:44:13 +0200 Received: from ensibm.imag.fr (ensibm.imag.fr [195.221.228.8]) by ensimag.imag.fr (8.13.8/8.13.8/ImagV2.1.r_ens) with ESMTP id r5CFiEVu015038; Wed, 12 Jun 2013 17:44:14 +0200 Received: from tohwi-K50IE.imag.fr (ensibm [195.221.228.8]) by ensibm.imag.fr (8.13.8/8.13.8/ImagV2.1.sb_ens.pm) with ESMTP id r5CFhu5x014096; Wed, 12 Jun 2013 17:44:14 +0200 X-Mailer: git-send-email 1.8.3.rc3.18.g21a7b2c In-Reply-To: <1371051828-12866-1-git-send-email-celestin.matte@ensimag.fr> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Wed, 12 Jun 2013 17:44:13 +0200 (CEST) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Local variable $url has the same name as a global variable. Changing th= e name of the local variable prevents future possible misunderstanding. Signed-off-by: C=C3=A9lestin Matte Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki.perl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-t= o-git/git-remote-mediawiki.perl index 44c5e0e..63d1530 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -454,14 +454,14 @@ sub get_mw_mediafile_for_page_revision { } =20 sub download_mw_mediafile { - my $url =3D shift; + my $download_url =3D shift; =20 - my $response =3D $mediawiki->{ua}->get($url); + my $response =3D $mediawiki->{ua}->get($download_url); if ($response->code =3D=3D 200) { return $response->decoded_content; } else { print STDERR "Error downloading mediafile from :\n"; - print STDERR "URL: $url\n"; + print STDERR "URL: $download_url\n"; print STDERR "Server response: " . $response->code . " " . $response= ->message . "\n"; exit 1; } --=20 1.8.3.rc3.18.g21a7b2c