From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?C=C3=A9lestin=20Matte?= Subject: [PATCH v5 26/31] git-remote-mediawiki: Put non-trivial numeric values in constants. Date: Wed, 12 Jun 2013 17:43:43 +0200 Message-ID: <1371051828-12866-27-git-send-email-celestin.matte@ensimag.fr> References: <1371051828-12866-1-git-send-email-celestin.matte@ensimag.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: benoit.person@ensimag.fr, matthieu.moy@grenoble-inp.fr, =?UTF-8?q?C=C3=A9lestin=20Matte?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Jun 12 17:44:40 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UmnDy-0007CJ-GB for gcvg-git-2@plane.gmane.org; Wed, 12 Jun 2013 17:44:38 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757039Ab3FLPo2 convert rfc822-to-quoted-printable (ORCPT ); Wed, 12 Jun 2013 11:44:28 -0400 Received: from mx1.imag.fr ([129.88.30.5]:43477 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756974Ab3FLPoX (ORCPT ); Wed, 12 Jun 2013 11:44:23 -0400 Received: from ensimag.imag.fr (ensimag.imag.fr [195.221.228.12]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id r5CFiI9H028860 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 Jun 2013 17:44:20 +0200 Received: from ensibm.imag.fr (ensibm.imag.fr [195.221.228.8]) by ensimag.imag.fr (8.13.8/8.13.8/ImagV2.1.r_ens) with ESMTP id r5CFiKSW015097; Wed, 12 Jun 2013 17:44:20 +0200 Received: from tohwi-K50IE.imag.fr (ensibm [195.221.228.8]) by ensibm.imag.fr (8.13.8/8.13.8/ImagV2.1.sb_ens.pm) with ESMTP id r5CFhu6B014096; Wed, 12 Jun 2013 17:44:20 +0200 X-Mailer: git-send-email 1.8.3.rc3.18.g21a7b2c In-Reply-To: <1371051828-12866-1-git-send-email-celestin.matte@ensimag.fr> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Wed, 12 Jun 2013 17:44:20 +0200 (CEST) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Non-trivial numeric values (e.g., different from 0, 1 and 2) are placed= in constants at the top of the code to be easily modifiable and to make mo= re sense Signed-off-by: C=C3=A9lestin Matte Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki.perl | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-t= o-git/git-remote-mediawiki.perl index 209dbe1..f4a63fb 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -42,6 +42,16 @@ use constant EMPTY_MESSAGE =3D> '*Empty MediaWiki Me= ssage*'; =20 use constant EMPTY =3D> q{}; =20 +# Number of pages taken into account at once in submodule get_mw_page_= list +use constant SLICE_SIZE =3D> 50; + +# Number of linked mediafile to get at once in get_linked_mediafiles +# The query is split in small batches because of the MW API limit of +# the number of links to be returned (500 links max). +use constant BATCH_SIZE =3D> 10; + +use constant HTTP_CODE_OK =3D> 200; + if (@ARGV !=3D 2) { exit_error_usage(); } @@ -223,13 +233,13 @@ sub get_mw_page_list { my $pages =3D shift; my @some_pages =3D @$page_list; while (@some_pages) { - my $last_page =3D 50; + my $last_page =3D SLICE_SIZE; if ($#some_pages < $last_page) { $last_page =3D $#some_pages; } my @slice =3D @some_pages[0..$last_page]; get_mw_first_pages(\@slice, $pages); - @some_pages =3D @some_pages[51..$#some_pages]; + @some_pages =3D @some_pages[(SLICE_SIZE + 1)..$#some_pages]; } return; } @@ -385,9 +395,7 @@ sub get_linked_mediafiles { my $pages =3D shift; my @titles =3D map { $_->{title} } values(%{$pages}); =20 - # The query is split in small batches because of the MW API limit of - # the number of links to be returned (500 links max). - my $batch =3D 10; + my $batch =3D BATCH_SIZE; while (@titles) { if ($#titles < $batch) { $batch =3D $#titles; @@ -469,7 +477,7 @@ sub download_mw_mediafile { my $download_url =3D shift; =20 my $response =3D $mediawiki->{ua}->get($download_url); - if ($response->code =3D=3D 200) { + if ($response->code =3D=3D HTTP_CODE_OK) { return $response->decoded_content; } else { print {*STDERR} "Error downloading mediafile from :\n"; --=20 1.8.3.rc3.18.g21a7b2c