From: "Célestin Matte" <celestin.matte@ensimag.fr>
To: git@vger.kernel.org
Cc: benoit.person@ensimag.fr, matthieu.moy@grenoble-inp.fr,
"Célestin Matte" <celestin.matte@ensimag.fr>
Subject: [PATCH v5 07/31] git-remote-mediawiki: Rewrite unclear line of instructions
Date: Wed, 12 Jun 2013 17:43:24 +0200 [thread overview]
Message-ID: <1371051828-12866-8-git-send-email-celestin.matte@ensimag.fr> (raw)
In-Reply-To: <1371051828-12866-1-git-send-email-celestin.matte@ensimag.fr>
Subroutines' parameters should be assigned to variable before doing anything
else
Besides, existing instruction affected a variable inside a "if", which break
Git's coding style
Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
---
contrib/mw-to-git/git-remote-mediawiki.perl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
index 431e063..2db6467 100755
--- a/contrib/mw-to-git/git-remote-mediawiki.perl
+++ b/contrib/mw-to-git/git-remote-mediawiki.perl
@@ -1333,7 +1333,8 @@ sub get_mw_namespace_id {
}
sub get_mw_namespace_id_for_page {
- if (my ($namespace) = $_[0] =~ /^([^:]*):/) {
+ my $namespace = shift;
+ if ($namespace =~ /^([^:]*):/) {
return get_mw_namespace_id($namespace);
} else {
return;
--
1.8.3.rc3.18.g21a7b2c
next prev parent reply other threads:[~2013-06-12 15:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 15:43 [PATCH v5 00/31] Follow perlcritic's recommandations Célestin Matte
2013-06-12 15:43 ` [PATCH v5 01/31] git-remote-mediawiki: Make a regexp clearer Célestin Matte
2013-06-12 15:43 ` [PATCH v5 02/31] git-remote-mediawiki: Move "use warnings;" before any instruction Célestin Matte
2013-06-12 15:43 ` [PATCH v5 03/31] git-remote-mediawiki: Replace :utf8 by :encoding(UTF-8) Célestin Matte
2013-06-12 15:43 ` [PATCH v5 04/31] git-remote-mediawiki: Always end a subroutine with a return Célestin Matte
2013-06-12 15:43 ` [PATCH v5 05/31] git-remote-mediawiki: Move a variable declaration at the top of the code Célestin Matte
2013-06-12 15:43 ` [PATCH v5 06/31] git-remote-mediawiki: Change syntax of map calls Célestin Matte
2013-06-12 15:43 ` Célestin Matte [this message]
2013-06-12 15:43 ` [PATCH v5 08/31] git-remote-mediawiki: Remove useless regexp modifier (m) Célestin Matte
2013-06-12 15:43 ` [PATCH v5 09/31] git-remote-mediawiki: Change the behaviour of a split Célestin Matte
2013-06-12 15:43 ` [PATCH v5 10/31] git-remote-mediawiki: Change separator of some regexps Célestin Matte
2013-06-12 15:43 ` [PATCH v5 11/31] git-remote-mediawiki: Change style in a regexp Célestin Matte
2013-06-12 15:43 ` [PATCH v5 12/31] " Célestin Matte
2013-06-12 15:43 ` [PATCH v5 13/31] git-remote-mediawiki: Add newline in the end of die() error messages Célestin Matte
2013-06-12 15:43 ` [PATCH v5 14/31] git-remote-mediawiki: Change the name of a variable Célestin Matte
2013-06-12 15:43 ` [PATCH v5 15/31] git-remote-mediawiki: Turn double-negated expressions into simple expressions Célestin Matte
2013-06-12 15:43 ` [PATCH v5 16/31] git-remote-mediawiki: Remove unused variable $entry Célestin Matte
2013-06-12 15:43 ` [PATCH v5 17/31] git-remote-mediawiki: Rename a variable ($last) which has the name of a keyword Célestin Matte
2013-06-12 15:43 ` [PATCH v5 18/31] git-remote-mediawiki: Assign a variable as undef and make proper indentation Célestin Matte
2013-06-12 15:43 ` [PATCH v5 19/31] git-remote-mediawiki: Check return value of open Célestin Matte
2013-06-12 15:43 ` [PATCH v5 20/31] git-remote-mediawiki: remove import of unused open2 Célestin Matte
2013-06-12 15:43 ` [PATCH v5 21/31] git-remote-mediawiki: Put long code into a subroutine Célestin Matte
2013-06-12 15:43 ` [PATCH v5 22/31] git-remote-mediawiki: Modify strings for a better coding-style Célestin Matte
2013-06-12 15:43 ` [PATCH v5 23/31] git-remote-mediawiki: Brace file handles for print for more clarity Célestin Matte
2013-06-12 15:43 ` [PATCH v5 24/31] git-remote-mediawiki: Replace "unless" statements with negated "if" statements Célestin Matte
2013-06-12 15:43 ` [PATCH v5 25/31] git-remote-mediawiki: Don't use quotes for empty strings Célestin Matte
2013-06-12 15:43 ` [PATCH v5 26/31] git-remote-mediawiki: Put non-trivial numeric values in constants Célestin Matte
2013-06-12 15:43 ` [PATCH v5 27/31] git-remote-mediawiki: Fix a typo ("mediwiki" instead of "mediawiki") Célestin Matte
2013-06-12 15:43 ` [PATCH v5 28/31] git-remote-mediawiki: Clearly rewrite double dereference Célestin Matte
2013-06-12 15:43 ` [PATCH v5 29/31] git-remote-mediawiki: Add a .perlcriticrc file Célestin Matte
2013-06-12 15:43 ` [PATCH v5 30/31] git-remote-mediawiki: add a perlcritic rule in Makefile Célestin Matte
2013-06-12 15:43 ` [PATCH v5 31/31] git-remote-mediawiki: Make error message more precise Célestin Matte
2013-06-12 20:02 ` [PATCH v5 00/31] Follow perlcritic's recommandations Matthieu Moy
2013-06-12 20:34 ` Célestin Matte
2013-06-12 20:47 ` Célestin Matte
2013-06-12 21:23 ` Eric Sunshine
2013-06-12 21:12 ` Matthieu Moy
2013-06-12 21:15 ` Célestin Matte
2013-06-12 22:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371051828-12866-8-git-send-email-celestin.matte@ensimag.fr \
--to=celestin.matte@ensimag.fr \
--cc=benoit.person@ensimag.fr \
--cc=git@vger.kernel.org \
--cc=matthieu.moy@grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).