git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 2/2] pull: clarify the large && { ... } form
Date: Fri, 14 Jun 2013 14:26:18 +0530	[thread overview]
Message-ID: <1371200178-9927-3-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1371200178-9927-1-git-send-email-artagnon@gmail.com>

Remove the large && { ... } form, as the block can be confused with a
function block.  Use a simple if-condition instead.  No functional
changes.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 git-pull.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/git-pull.sh b/git-pull.sh
index fb01763..babf009 100755
--- a/git-pull.sh
+++ b/git-pull.sh
@@ -195,7 +195,7 @@ error_on_no_merge_candidates () {
 	exit 1
 }
 
-test true = "$rebase" && {
+if test true = "$rebase"; then
 	if ! git rev-parse -q --verify HEAD >/dev/null
 	then
 		# On an unborn branch
@@ -220,7 +220,8 @@ test true = "$rebase" && {
 			break
 		fi
 	done
-}
+fi
+
 orig_head=$(git rev-parse -q --verify HEAD)
 git fetch $verbosity $progress $dry_run $recurse_submodules --update-head-ok "$@" || exit 1
 test -z "$dry_run" || exit 0
-- 
1.8.3.1.379.gb74074e.dirty

  parent reply	other threads:[~2013-06-14  8:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  8:56 [PATCH 0/2] Rebasing pull with autostash Ramkumar Ramachandra
2013-06-14  8:56 ` [PATCH 1/2] pull: respect rebase.autostash Ramkumar Ramachandra
2013-06-14  9:13   ` Matthieu Moy
2013-06-14 10:41     ` Ramkumar Ramachandra
2013-06-14 11:59       ` Phil Hord
2013-06-14 18:26     ` Junio C Hamano
2013-06-14 12:12   ` Phil Hord
2013-06-14 12:21     ` Phil Hord
2013-06-14 12:29     ` John Keeping
2013-06-14 12:41       ` Phil Hord
2013-06-14 12:46       ` Ramkumar Ramachandra
2013-06-14  8:56 ` Ramkumar Ramachandra [this message]
2013-06-14  9:09   ` [PATCH 2/2] pull: clarify the large && { ... } form Matthieu Moy
2013-06-14 10:47     ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371200178-9927-3-git-send-email-artagnon@gmail.com \
    --to=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).