From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] t/t5800-remote-testpy: skip all tests if not built
Date: Wed, 19 Jun 2013 01:36:46 +0530 [thread overview]
Message-ID: <1371586006-16289-1-git-send-email-artagnon@gmail.com> (raw)
416fda6 (build: do not install git-remote-testpy, 2013-05-24) added
git-remote-testpy to NO_INSTALL, with the intent of excluding it from
the default install. This is typically meant for scripts in contrib/
with their own testsuite and Makefile (e.g. git remote-bzr, git
remote-hg). Unfortunately, git-remote-testpy.py is a toplevel script
without its own Makefile; its testsuite is located in
t/t5800-remote-testpy.sh.
What this means is that git-remote-testpy is not built by default (when
'make' is invoked), but t5800 runs by default (like every other test in
t/). As a result, a new contributor cloning git.git and running 'make
test' for the first time will notice test failures. Fix this
unpleasantness by patching t5800 to check for git-remote-testpy as a
prerequisite.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
Candidate for maint?
t/t5800-remote-testpy.sh | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/t/t5800-remote-testpy.sh b/t/t5800-remote-testpy.sh
index 1e683d4..9df35b5 100755
--- a/t/t5800-remote-testpy.sh
+++ b/t/t5800-remote-testpy.sh
@@ -12,6 +12,11 @@ if ! test_have_prereq PYTHON ; then
test_done
fi
+if ! test -e "$GIT_BUILD_DIR/git-remote-testpy"; then
+ skip_all='skipping python remote-helper tests, git-remote-testpy not built'
+ test_done
+fi
+
"$PYTHON_PATH" -c '
import sys
if sys.hexversion < 0x02040000:
--
1.8.3.1.379.g1f0e7d7
next reply other threads:[~2013-06-18 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 20:06 Ramkumar Ramachandra [this message]
2013-06-18 20:28 ` [PATCH] t/t5800-remote-testpy: skip all tests if not built Junio C Hamano
2013-06-18 20:35 ` Ramkumar Ramachandra
2013-06-21 5:31 ` Jeff King
2013-06-21 6:37 ` Ramkumar Ramachandra
2013-06-21 6:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371586006-16289-1-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).