git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 0/4] Make check-{attr,ignore} -z consistent
Date: Thu, 11 Jul 2013 23:18:43 -0700	[thread overview]
Message-ID: <1373609927-3244-1-git-send-email-gitster@pobox.com> (raw)

A command that has to deal with input/output that may contain LF
needs to offer the "-z" (--nul-terminated-records) option, and if it
does not support separate --nul-terminated-{input,output} options,
the "-z" option should govern both input and output.  A caller that
uses "-z" knows that the paths it feeds to these commands as input
may have LF that cannot be expressed in LF delimited input format,
and the output from these commands do contain the same paths, so
there is no way for their output to be expressed unambiguously for
an input that requires "-z".

Unfortunately, "git check-attr -z" was broken and ignored the option
on the output side.  This is a backward-incompatible fix, so we may
need to add a "checkAttr.brokenZ" configuration to allow people to
keep the existing breakage on top of these fixes, and then flip the
default at Git 2.0 boundary (sometime early next year).

Credit goes to Eric Sunshine for finding this discrepancy
($gmane/230158).

Junio C Hamano (4):
  check-ignore: the name of the character is NUL, not NULL
  check-attr: the name of the character is NUL, not NULL
  check-ignore -z: a single -z should apply to both input and output
  check-attr -z: a single -z should apply to both input and output

 Documentation/git-check-attr.txt |  9 +++++++--
 builtin/check-attr.c             | 20 ++++++++++++++------
 builtin/check-ignore.c           | 12 ++++++------
 3 files changed, 27 insertions(+), 14 deletions(-)

-- 
1.8.3.2-911-g2c4daa5

             reply	other threads:[~2013-07-12  6:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12  6:18 Junio C Hamano [this message]
2013-07-12  6:18 ` [PATCH 1/4] check-ignore: the name of the character is NUL, not NULL Junio C Hamano
2013-07-12  6:18 ` [PATCH 2/4] check-attr: " Junio C Hamano
2013-07-12  6:18 ` [PATCH 3/4] check-ignore -z: a single -z should apply to both input and output Junio C Hamano
2013-07-12  6:18 ` [PATCH 4/4] check-attr " Junio C Hamano
2013-07-12  6:55 ` [PATCH 0/4] Make check-{attr,ignore} -z consistent Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373609927-3244-1-git-send-email-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).