git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 3/4] check-ignore -z: a single -z should apply to both input and output
Date: Thu, 11 Jul 2013 23:18:46 -0700	[thread overview]
Message-ID: <1373609927-3244-4-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1373609927-3244-1-git-send-email-gitster@pobox.com>

Unless a command has separate --nul-terminated-{input,output}
options, the --nul-terminated-records (-z) option should apply
to both input and output for consistency.  The caller knows that its
input paths may need to be protected for LF, and the program shows
these problematic paths to its output.

The code already did the right thing.  Only the help text needs
fixing.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/check-ignore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/check-ignore.c b/builtin/check-ignore.c
index be22bce..03e509e 100644
--- a/builtin/check-ignore.c
+++ b/builtin/check-ignore.c
@@ -21,7 +21,7 @@ static const struct option check_ignore_options[] = {
 	OPT_BOOLEAN(0, "stdin", &stdin_paths,
 		    N_("read file names from stdin")),
 	OPT_BOOLEAN('z', NULL, &nul_term_line,
-		    N_("input paths are terminated by a NUL character")),
+		    N_("terminate input and output records by a NUL character")),
 	OPT_END()
 };
 
-- 
1.8.3.2-911-g2c4daa5

  parent reply	other threads:[~2013-07-12  6:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12  6:18 [PATCH 0/4] Make check-{attr,ignore} -z consistent Junio C Hamano
2013-07-12  6:18 ` [PATCH 1/4] check-ignore: the name of the character is NUL, not NULL Junio C Hamano
2013-07-12  6:18 ` [PATCH 2/4] check-attr: " Junio C Hamano
2013-07-12  6:18 ` Junio C Hamano [this message]
2013-07-12  6:18 ` [PATCH 4/4] check-attr -z: a single -z should apply to both input and output Junio C Hamano
2013-07-12  6:55 ` [PATCH 0/4] Make check-{attr,ignore} -z consistent Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373609927-3244-4-git-send-email-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).